Reduce macro usage in turbo-tasks-testing #8832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
a0f10c1 to
2085efb
Compare
arlyon
reviewed
Jul 25, 2024
Changes the `run` macro into a function.
8dc3955 to
44e639e
Compare
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
## What? Replaces the `turbo_tasks_testing::run!` macro with a `run` function that requires an opaque registration argument generated by the `register!` macro. ## Why? A few reasons: - `cargo fmt` doesn't work inside macros (with the exception of function-like macros), so our tests weren't getting autoformatted. - When a test fails, it was hard to know what line it failed on, because the failure is attributed to the first line of the macro usage. ## Related Changes - This also changes many (though not all) `.await?`s into `.await.unwrap()`s. The reason for this is similar: it's easier to attribute the line that causes a panic than the line that returns an error. I left some tests alone as there were more `?`s than I felt like changing. - `register!()` now takes an optional list of other register functions to call. The tests in `turbo-tasks-fetch` use this. ## Testing Instructions ``` cargo nextest run ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
## What? Replaces the `turbo_tasks_testing::run!` macro with a `run` function that requires an opaque registration argument generated by the `register!` macro. ## Why? A few reasons: - `cargo fmt` doesn't work inside macros (with the exception of function-like macros), so our tests weren't getting autoformatted. - When a test fails, it was hard to know what line it failed on, because the failure is attributed to the first line of the macro usage. ## Related Changes - This also changes many (though not all) `.await?`s into `.await.unwrap()`s. The reason for this is similar: it's easier to attribute the line that causes a panic than the line that returns an error. I left some tests alone as there were more `?`s than I felt like changing. - `register!()` now takes an optional list of other register functions to call. The tests in `turbo-tasks-fetch` use this. ## Testing Instructions ``` cargo nextest run ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
## What? Replaces the `turbo_tasks_testing::run!` macro with a `run` function that requires an opaque registration argument generated by the `register!` macro. ## Why? A few reasons: - `cargo fmt` doesn't work inside macros (with the exception of function-like macros), so our tests weren't getting autoformatted. - When a test fails, it was hard to know what line it failed on, because the failure is attributed to the first line of the macro usage. ## Related Changes - This also changes many (though not all) `.await?`s into `.await.unwrap()`s. The reason for this is similar: it's easier to attribute the line that causes a panic than the line that returns an error. I left some tests alone as there were more `?`s than I felt like changing. - `register!()` now takes an optional list of other register functions to call. The tests in `turbo-tasks-fetch` use this. ## Testing Instructions ``` cargo nextest run ```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
## What? Replaces the `turbo_tasks_testing::run!` macro with a `run` function that requires an opaque registration argument generated by the `register!` macro. ## Why? A few reasons: - `cargo fmt` doesn't work inside macros (with the exception of function-like macros), so our tests weren't getting autoformatted. - When a test fails, it was hard to know what line it failed on, because the failure is attributed to the first line of the macro usage. ## Related Changes - This also changes many (though not all) `.await?`s into `.await.unwrap()`s. The reason for this is similar: it's easier to attribute the line that causes a panic than the line that returns an error. I left some tests alone as there were more `?`s than I felt like changing. - `register!()` now takes an optional list of other register functions to call. The tests in `turbo-tasks-fetch` use this. ## Testing Instructions ``` cargo nextest run ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replaces the
turbo_tasks_testing::run!macro with arunfunction that requires an opaque registration argument generated by theregister!macro.Why?
A few reasons:
cargo fmtdoesn't work inside macros (with the exception of function-like macros), so our tests weren't getting autoformatted.Related Changes
This also changes many (though not all)
.await?s into.await.unwrap()s. The reason for this is similar: it's easier to attribute the line that causes a panic than the line that returns an error. I left some tests alone as there were more?s than I felt like changing.register!()now takes an optional list of other register functions to call. The tests inturbo-tasks-fetchuse this.Testing Instructions