Refactor cell reading to handle removed cells #8819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
This was referenced Jul 23, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
20590d1 to
9bf926c
Compare
af360db to
561efca
Compare
|
does it make sense to formalize the cell state machine using some rust library? There are a lot of types of transitions so it may clean up the logic |
arlyon
approved these changes
Jul 24, 2024
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Refactor cell reading to handle removed cells handle recomputation of cells on read use start event instead of done event when waiting for task reading That's how the Cell state changes:  ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Refactor cell reading to handle removed cells handle recomputation of cells on read use start event instead of done event when waiting for task reading That's how the Cell state changes:  ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Refactor cell reading to handle removed cells handle recomputation of cells on read use start event instead of done event when waiting for task reading That's how the Cell state changes:  ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Refactor cell reading to handle removed cells handle recomputation of cells on read use start event instead of done event when waiting for task reading That's how the Cell state changes:  ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8812 <!-- Benjamin Woodruff - Simplify some of the syntax used with VcRead<T> --> * vercel/turborepo#8823 <!-- hrmny - feat(turbopack): support analysing string concatenation --> * vercel/turborepo#8828 <!-- Tobias Koppers - change from failsafe_analyse to failsafe_parse --> * vercel/turborepo#8831 <!-- Alexander Lyon - make sure that all the taiki-e/install-action calls use our env --> * vercel/turborepo#8819 <!-- Tobias Koppers - Refactor cell reading to handle removed cells --> * vercel/turborepo#8038 <!-- Alexander Lyon - add tags to turbo tasks --> * vercel/turborepo#8807 <!-- Tobias Koppers - box Scheduled task state to save memory --> * vercel/turborepo#8170 <!-- Tobias Koppers - Drop excessive cells after task reexecution -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor cell reading to handle removed cells
handle recomputation of cells on read
use start event instead of done event when waiting for task reading
That's how the Cell state changes:
Testing Instructions