Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid implementing Eq on Completion #8818

Merged
merged 2 commits into from
Jul 25, 2024
Merged

avoid implementing Eq on Completion #8818

merged 2 commits into from
Jul 25, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 23, 2024

Description

It's probably not want to want. You want ptr_eq instead.

Testing Instructions

sokra added 2 commits July 23, 2024 12:02
@sokra
avoid implementation Eq on Completion
390506c 
It's probably not want to want. You want ptr_eq instead.
@sokra
add comment
782feee
@sokra sokra requested a review from a team as a code owner July 23, 2024 10:04
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 10:07am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2024 10:07am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 23, 2024 10:07am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 23, 2024 10:07am
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 23, 2024 10:07am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 23, 2024 10:07am
examples-native-web ⬜️ Ignored (Inspect) Jul 23, 2024 10:07am
examples-svelte-web ⬜️ Ignored (Inspect) Jul 23, 2024 10:07am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 10:07am
examples-vite-web ⬜️ Ignored (Inspect) Jul 23, 2024 10:07am

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

crates/next-core/src/next_telemetry.rs:42:9: �[38;5;9merror[E0271]: type mismatch resolving `<DiagnosticPayload as VcValueType>::Read == VcTransparentRead<DiagnosticPayload, HashMap<RcStr, _>, _>`
crates/next-core/src/next_telemetry.rs:82:9: �[38;5;9merror[E0271]: type mismatch resolving `<DiagnosticPayload as VcValueType>::Read == VcTransparentRead<DiagnosticPayload, HashMap<RcStr, _>, _>`
error: could not compile `next-core` (lib) due to 2 previous errors

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (linux)

See workflow summary for details

@sokra sokra changed the title avoid implementation Eq on Completion avoid implementing Eq on Completion Jul 23, 2024
bgw
bgw approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@sokra sokra merged commit cce3d88 into main Jul 25, 2024
53 of 60 checks passed
@sokra sokra deleted the sokra/completion-eq branch July 25, 2024 06:21
@kdy1 kdy1 mentioned this pull request Jul 25, 2024
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
avoid implementing Eq on Completion (vercel/turborepo#8818)
b51b904 
### Description

It's probably not want to want. You want ptr_eq instead.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
avoid implementing Eq on Completion (vercel/turborepo#8818)
dde6629 
### Description

It's probably not want to want. You want ptr_eq instead.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
avoid implementing Eq on Completion (vercel/turborepo#8818)
591679b 
### Description

It's probably not want to want. You want ptr_eq instead.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
avoid implementing Eq on Completion (vercel/turborepo#8818)
1c04b10 
### Description

It's probably not want to want. You want ptr_eq instead.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgw bgw bgw approved these changes

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokra @bgw @kdy1