Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve tree shaking #8781

Merged
merged 66 commits into from
Jul 25, 2024
Merged

feat: Improve tree shaking #8781

merged 66 commits into from
Jul 25, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 18, 2024

Description

I'm still struggling to make next.js CI work well with tree shaking.

Testing Instructions

@kdy1 kdy1 self-assigned this Jul 18, 2024
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 6:43am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 6:43am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 6:43am

Copy link
Contributor

github-actions bot commented Jul 18, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jul 18, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jul 18, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 force-pushed the kdy1/tree-shake branch from 301ae22 to fb3dfff Compare July 18, 2024 03:58
@kdy1 kdy1 force-pushed the kdy1/tree-shake branch from d688b28 to 13f533e Compare July 18, 2024 14:03
@kdy1 kdy1 force-pushed the kdy1/tree-shake branch from 13f533e to 41cfd3b Compare July 19, 2024 04:02
__turbopack_part__: 0
};
import { a } from "__TURBOPACK_PART__" assert {
__turbopack_part__: 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated, so there's no ReferenceError.

@kdy1 kdy1 merged commit 681bfab into main Jul 25, 2024
54 of 55 checks passed
@kdy1 kdy1 deleted the kdy1/tree-shake branch July 25, 2024 06:50
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

I'm still struggling to make next.js CI work well with tree shaking.

- #66689
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

I'm still struggling to make next.js CI work well with tree shaking.

- #66689
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

I'm still struggling to make next.js CI work well with tree shaking.

- #66689
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

I'm still struggling to make next.js CI work well with tree shaking.

- #66689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants