Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update swc_core to v0.96.5" #8696

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Revert "Update swc_core to v0.96.5" #8696

merged 1 commit into from
Jul 9, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 9, 2024

Reverts #8646

I failed to make next.js CI pass, so I'm creating this PR to unblock other team members updating turbopack

@kdy1 kdy1 requested review from a team as code owners July 9, 2024 03:20
@kdy1 kdy1 requested review from mehulkar and codybrouwers July 9, 2024 03:20
@kdy1 kdy1 self-assigned this Jul 9, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 3:22am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 3:22am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am
examples-native-web ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am
examples-svelte-web ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am
examples-tailwind-web ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am
examples-vite-web ⬜️ Ignored (Inspect) Jul 9, 2024 3:22am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `either`.
    ... required by package `browserslist-rs v0.16.0`
    ... which satisfies dependency `browserslist-rs = "^0.16.0"` of package `turbopack-core v0.1.0 (https://github.com/vercel/turbo?rev=6810d5a4938f721ca02526c7d159dea903ec3d91#ede5946a)`
    ... which satisfies git dependency `turbopack-core` of package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=6810d5a4938f721ca02526c7d159dea903ec3d91#ede5946a)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-build-test v0.1.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/next-build-test)`
versions that meet the requirements `^1.12` are: 1.13.0, 1.12.0

all possible versions conflict with previously selected packages.

  previously selected package `either v1.10.0`
    ... which satisfies dependency `either = "^1"` (locked to 1.10.0) of package `next-custom-transforms v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/next-custom-transforms)`
    ... which satisfies path dependency `next-custom-transforms` (locked to 0.0.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`

failed to select a version for `either` which could resolve this conflict

See job summary for details

@kdy1 kdy1 mentioned this pull request Jul 9, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit ac6250d into main Jul 9, 2024
57 of 60 checks passed
@sokra sokra deleted the revert-8646-kdy1/swc-core-96-1 branch July 9, 2024 04:33
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kdy1
Revert "Update swc_core to v0.96.5" (vercel/turborepo#8696)
b5637dc 
Reverts vercel/turborepo#8646

I failed to make next.js CI pass, so I'm creating this PR to unblock
other team members updating turbopack
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1
Revert "Update swc_core to v0.96.5" (vercel/turborepo#8696)
6d78de9 
Reverts vercel/turborepo#8646

I failed to make next.js CI pass, so I'm creating this PR to unblock
other team members updating turbopack
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1
Revert "Update swc_core to v0.96.5" (vercel/turborepo#8696)
e62ccce 
Reverts vercel/turborepo#8646

I failed to make next.js CI pass, so I'm creating this PR to unblock
other team members updating turbopack
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kdy1
Revert "Update swc_core to v0.96.5" (vercel/turborepo#8696)
bdac720 
Reverts vercel/turborepo#8646

I failed to make next.js CI pass, so I'm creating this PR to unblock
other team members updating turbopack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@mehulkar mehulkar Awaiting requested review from mehulkar mehulkar is a code owner automatically assigned from vercel/turbo-oss

@codybrouwers codybrouwers Awaiting requested review from codybrouwers codybrouwers is a code owner automatically assigned from vercel/turbo-oss

Assignees

@kdy1 kdy1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @sokra