add unloading of tasks to GC #8671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
Logs
See job summary for details |
arlyon
reviewed
Jul 8, 2024
arlyon
reviewed
Jul 8, 2024
arlyon
reviewed
Jul 8, 2024
arlyon
reviewed
Jul 8, 2024
arlyon
approved these changes
Jul 8, 2024
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jul 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix equal checks for cells and output --> * vercel/turborepo#8671 <!-- Tobias Koppers - add unloading of tasks to GC --> * vercel/turborepo#8749 <!-- Tobias Koppers - fix unloading stateful check --> * vercel/turborepo#8750 <!-- Tobias Koppers - upgrade deps to avoid conflict with next.js -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Inactive tasks can be completely unloaded. This disconnects them from the graph and frees nearly all memory (except for the TaskId mapping). When running GC for a task we check if it's inactive and unload it when it is. But we also need to enqueue a task for GC again when it becomes inactive. So we maintain a queue of potentially inactive tasks and walk the children during GC.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Inactive tasks can be completely unloaded. This disconnects them from the graph and frees nearly all memory (except for the TaskId mapping). When running GC for a task we check if it's inactive and unload it when it is. But we also need to enqueue a task for GC again when it becomes inactive. So we maintain a queue of potentially inactive tasks and walk the children during GC.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Inactive tasks can be completely unloaded. This disconnects them from the graph and frees nearly all memory (except for the TaskId mapping). When running GC for a task we check if it's inactive and unload it when it is. But we also need to enqueue a task for GC again when it becomes inactive. So we maintain a queue of potentially inactive tasks and walk the children during GC.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Inactive tasks can be completely unloaded. This disconnects them from the graph and frees nearly all memory (except for the TaskId mapping). When running GC for a task we check if it's inactive and unload it when it is. But we also need to enqueue a task for GC again when it becomes inactive. So we maintain a queue of potentially inactive tasks and walk the children during GC.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8721 <!-- Tobias Koppers - fix equal checks for cells and output --> * vercel/turborepo#8671 <!-- Tobias Koppers - add unloading of tasks to GC --> * vercel/turborepo#8749 <!-- Tobias Koppers - fix unloading stateful check --> * vercel/turborepo#8750 <!-- Tobias Koppers - upgrade deps to avoid conflict with next.js -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inactive tasks can be completely unloaded. This disconnects them from the graph and frees nearly all memory (except for the TaskId mapping).
When running GC for a task we check if it's inactive and unload it when it is.
But we also need to enqueue a task for GC again when it becomes inactive. So we maintain a queue of potentially inactive tasks and walk the children during GC.