fix: Fix ECMAScript analyzer #8656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
|
✅ This change can build |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
sokra
requested changes
Jul 3, 2024
Comment on lines
1
to
3
| a = ("" | `${a}x` | ???*0*) | ||
| - *0* a | ||
| ⚠️ pattern without value |
bgw
approved these changes
Jul 4, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description I faced this bug while working on vercel/turborepo#8523. Tree shaking inevitably creates direct imports for let bindings, and when the LHS of `+=` is imported/exported, it triggers a bug. The problematic input file looks like ```js // Combined load times for loading client components let clientComponentLoadStart = 0 let clientComponentLoadTimes = 0 let clientComponentLoadCount = 0 export function wrapClientComponentLoader(ComponentMod: any) { if (!('performance' in globalThis)) { return ComponentMod.__next_app__ } return { require: (...args: any[]) => { const startTime = performance.now() if (clientComponentLoadStart === 0) { clientComponentLoadStart = startTime } try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.require(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, loadChunk: (...args: any[]) => { const startTime = performance.now() try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.loadChunk(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, } } export function getClientComponentLoaderMetrics( options: { reset?: boolean } = {} ) { const metrics = clientComponentLoadStart === 0 ? undefined : { clientComponentLoadStart, clientComponentLoadTimes, clientComponentLoadCount, } if (options.reset) { clientComponentLoadStart = 0 clientComponentLoadTimes = 0 clientComponentLoadCount = 0 } return metrics } ``` and it works if I apply this PR or I replace `clientComponentLoadTimes += performance.now() - startTime` with `clientComponentLoadTimes = clientComponentLoadTimes + performance.now() - startTime`. ### Testing Instructions Test references changed quite a lot.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description I faced this bug while working on vercel/turborepo#8523. Tree shaking inevitably creates direct imports for let bindings, and when the LHS of `+=` is imported/exported, it triggers a bug. The problematic input file looks like ```js // Combined load times for loading client components let clientComponentLoadStart = 0 let clientComponentLoadTimes = 0 let clientComponentLoadCount = 0 export function wrapClientComponentLoader(ComponentMod: any) { if (!('performance' in globalThis)) { return ComponentMod.__next_app__ } return { require: (...args: any[]) => { const startTime = performance.now() if (clientComponentLoadStart === 0) { clientComponentLoadStart = startTime } try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.require(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, loadChunk: (...args: any[]) => { const startTime = performance.now() try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.loadChunk(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, } } export function getClientComponentLoaderMetrics( options: { reset?: boolean } = {} ) { const metrics = clientComponentLoadStart === 0 ? undefined : { clientComponentLoadStart, clientComponentLoadTimes, clientComponentLoadCount, } if (options.reset) { clientComponentLoadStart = 0 clientComponentLoadTimes = 0 clientComponentLoadCount = 0 } return metrics } ``` and it works if I apply this PR or I replace `clientComponentLoadTimes += performance.now() - startTime` with `clientComponentLoadTimes = clientComponentLoadTimes + performance.now() - startTime`. ### Testing Instructions Test references changed quite a lot.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description I faced this bug while working on vercel/turborepo#8523. Tree shaking inevitably creates direct imports for let bindings, and when the LHS of `+=` is imported/exported, it triggers a bug. The problematic input file looks like ```js // Combined load times for loading client components let clientComponentLoadStart = 0 let clientComponentLoadTimes = 0 let clientComponentLoadCount = 0 export function wrapClientComponentLoader(ComponentMod: any) { if (!('performance' in globalThis)) { return ComponentMod.__next_app__ } return { require: (...args: any[]) => { const startTime = performance.now() if (clientComponentLoadStart === 0) { clientComponentLoadStart = startTime } try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.require(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, loadChunk: (...args: any[]) => { const startTime = performance.now() try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.loadChunk(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, } } export function getClientComponentLoaderMetrics( options: { reset?: boolean } = {} ) { const metrics = clientComponentLoadStart === 0 ? undefined : { clientComponentLoadStart, clientComponentLoadTimes, clientComponentLoadCount, } if (options.reset) { clientComponentLoadStart = 0 clientComponentLoadTimes = 0 clientComponentLoadCount = 0 } return metrics } ``` and it works if I apply this PR or I replace `clientComponentLoadTimes += performance.now() - startTime` with `clientComponentLoadTimes = clientComponentLoadTimes + performance.now() - startTime`. ### Testing Instructions Test references changed quite a lot.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description I faced this bug while working on vercel/turborepo#8523. Tree shaking inevitably creates direct imports for let bindings, and when the LHS of `+=` is imported/exported, it triggers a bug. The problematic input file looks like ```js // Combined load times for loading client components let clientComponentLoadStart = 0 let clientComponentLoadTimes = 0 let clientComponentLoadCount = 0 export function wrapClientComponentLoader(ComponentMod: any) { if (!('performance' in globalThis)) { return ComponentMod.__next_app__ } return { require: (...args: any[]) => { const startTime = performance.now() if (clientComponentLoadStart === 0) { clientComponentLoadStart = startTime } try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.require(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, loadChunk: (...args: any[]) => { const startTime = performance.now() try { clientComponentLoadCount += 1 return ComponentMod.__next_app__.loadChunk(...args) } finally { clientComponentLoadTimes += performance.now() - startTime } }, } } export function getClientComponentLoaderMetrics( options: { reset?: boolean } = {} ) { const metrics = clientComponentLoadStart === 0 ? undefined : { clientComponentLoadStart, clientComponentLoadTimes, clientComponentLoadCount, } if (options.reset) { clientComponentLoadStart = 0 clientComponentLoadTimes = 0 clientComponentLoadCount = 0 } return metrics } ``` and it works if I apply this PR or I replace `clientComponentLoadTimes += performance.now() - startTime` with `clientComponentLoadTimes = clientComponentLoadTimes + performance.now() - startTime`. ### Testing Instructions Test references changed quite a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I faced this bug while working on #8523. Tree shaking inevitably creates direct imports for let bindings, and when the LHS of
+=is imported/exported, it triggers a bug.The problematic input file looks like
and it works if I apply this PR or I replace
clientComponentLoadTimes += performance.now() - startTimewithclientComponentLoadTimes = clientComponentLoadTimes + performance.now() - startTime.Testing Instructions
Test references changed quite a lot.