Turbopack + Relay: correctly implement artifact_directory to fix multi-project test #8655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-project test Previously, if `artifact_directory` were set, artifacts would be resolved at a fixed location relative to each file. This correctly resolves them from the project root. Test Plan: With vercel/next.js#67403, `TURBOPACK_BUILD=1 TURBOPACK=1 pnpm test-dev test/integration/relay-graphql-swc-multi-project/test/index.test.js`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Skipped Deployments
|
|
✅ This change can build |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
bgw
approved these changes
Jul 3, 2024
…ix multi-project test
kdy1
approved these changes
Jul 3, 2024
…ix multi-project test
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…i-project test (vercel/turborepo#8655) Previously, if `artifact_directory` were set, artifacts would be resolved at a fixed location relative to each file. This correctly resolves them from the project root. Test Plan: With #67403, `TURBOPACK_BUILD=1 TURBOPACK=1 pnpm test-dev test/integration/relay-graphql-swc-multi-project/test/index.test.js`
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…i-project test (vercel/turborepo#8655) Previously, if `artifact_directory` were set, artifacts would be resolved at a fixed location relative to each file. This correctly resolves them from the project root. Test Plan: With #67403, `TURBOPACK_BUILD=1 TURBOPACK=1 pnpm test-dev test/integration/relay-graphql-swc-multi-project/test/index.test.js`
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…i-project test (vercel/turborepo#8655) Previously, if `artifact_directory` were set, artifacts would be resolved at a fixed location relative to each file. This correctly resolves them from the project root. Test Plan: With #67403, `TURBOPACK_BUILD=1 TURBOPACK=1 pnpm test-dev test/integration/relay-graphql-swc-multi-project/test/index.test.js`
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…i-project test (vercel/turborepo#8655) Previously, if `artifact_directory` were set, artifacts would be resolved at a fixed location relative to each file. This correctly resolves them from the project root. Test Plan: With #67403, `TURBOPACK_BUILD=1 TURBOPACK=1 pnpm test-dev test/integration/relay-graphql-swc-multi-project/test/index.test.js`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
artifact_directorywere set, artifacts would be resolved at a fixed location relative to each file. This correctly resolves them from the project root.Test Plan: With vercel/next.js#67403,
TURBOPACK_BUILD=1 TURBOPACK=1 pnpm test-dev test/integration/relay-graphql-swc-multi-project/test/index.test.js