Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box InProgress task state #8644

Merged
merged 2 commits into from
Jul 2, 2024
Merged

box InProgress task state #8644

merged 2 commits into from
Jul 2, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jul 2, 2024

Description

That saves 32 bytes per Task

Testing Instructions

@sokra sokra requested a review from a team as a code owner July 2, 2024 06:49
@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 6:51am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am
examples-native-web ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am
examples-svelte-web ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am
examples-tailwind-web ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am
examples-vite-web ⬜️ Ignored (Inspect) Jul 2, 2024 6:51am

@sokra sokra requested review from bgw and arlyon July 2, 2024 06:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `triomphe`.
    ... required by package `hstr v0.2.8`
    ... which satisfies dependency `hstr = "^0.2.8"` (locked to 0.2.8) of package `swc_atoms v0.6.7`
    ... which satisfies dependency `swc_atoms = "^0.6.5"` (locked to 0.6.7) of package `swc_core v0.95.4`
    ... which satisfies dependency `swc_core = "^0.95.4"` (locked to 0.95.4) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`
versions that meet the requirements `^0.1.11` (locked to 0.1.11) are: 0.1.11

all possible versions conflict with previously selected packages.

  previously selected package `triomphe v0.1.13`
    ... which satisfies dependency `triomphe = "^0.1.13"` of package `turbo-tasks v0.1.0 (https://github.com/vercel/turbo?rev=bc04a08b5ab513475d125da2308d21aab072724a#52ed46b3)`
    ... which satisfies git dependency `turbo-tasks` (locked to 0.1.0) of package `next-build-test v0.1.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/next-build-test)`

failed to select a version for `triomphe` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra requested a review from kdy1 July 2, 2024 09:21
@sokra sokra merged commit 5aba12d into main Jul 2, 2024
55 of 58 checks passed
@sokra sokra deleted the sokra/box-inprogress-task-state branch July 2, 2024 12:57
@bgw bgw mentioned this pull request Jul 3, 2024
Merged
bgw added a commit to vercel/next.js that referenced this pull request Jul 3, 2024
@bgw
[chore] Update turbopack to turbopack-240703.1 (#67406)
d19862a 
Tobias Koppers - fix typo (vercel/turborepo#8619)
Benjamin Woodruff - Store aggregate read/execute count statistics
(vercel/turborepo#8286)
Tobias Koppers - box InProgress task state (vercel/turborepo#8644)
Tobias Koppers - Task Edges Set/List (vercel/turborepo#8624)
Benjamin Woodruff - Memory: Use `triomphe::Arc` for `SharedReference`
(vercel/turborepo#8622)
Will Binns-Smith - chore: release npm packages (vercel/turborepo#8614)
Will Binns-Smith - devlow-bench: add git branch and sha to datapoints
(vercel/turborepo#8602)

---

Fixes a `triomphe` package version conflict between turbopack and swc by
bumping it from 0.1.11 to 0.1.13.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
box InProgress task state (vercel/turborepo#8644)
0dec5be 
### Description

That saves 32 bytes per Task

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
box InProgress task state (vercel/turborepo#8644)
22efbbb 
### Description

That saves 32 bytes per Task

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
box InProgress task state (vercel/turborepo#8644)
e51b95c 
### Description

That saves 32 bytes per Task

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
box InProgress task state (vercel/turborepo#8644)
81be6c4 
### Description

That saves 32 bytes per Task

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@bgw @ForsakenHarmony
[chore] Update turbopack to turbopack-240703.1 (#67406)
d153cba 
Tobias Koppers - fix typo (vercel/turborepo#8619)
Benjamin Woodruff - Store aggregate read/execute count statistics
(vercel/turborepo#8286)
Tobias Koppers - box InProgress task state (vercel/turborepo#8644)
Tobias Koppers - Task Edges Set/List (vercel/turborepo#8624)
Benjamin Woodruff - Memory: Use `triomphe::Arc` for `SharedReference`
(vercel/turborepo#8622)
Will Binns-Smith - chore: release npm packages (vercel/turborepo#8614)
Will Binns-Smith - devlow-bench: add git branch and sha to datapoints
(vercel/turborepo#8602)

---

Fixes a `triomphe` package version conflict between turbopack and swc by
bumping it from 0.1.11 to 0.1.13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@bgw bgw Awaiting requested review from bgw

@arlyon arlyon Awaiting requested review from arlyon

@kdy1 kdy1 Awaiting requested review from kdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @ForsakenHarmony