Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce resolve tasks for resolving #8451

Merged
merged 2 commits into from
Jun 12, 2024
Merged

reduce resolve tasks for resolving #8451

merged 2 commits into from
Jun 12, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 12, 2024

Description

That reduces the task count and improve memory usage

Testing Instructions

@sokra sokra requested a review from a team as a code owner June 12, 2024 07:32
@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 7:32am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 7:32am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am
examples-native-web ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am
examples-svelte-web ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am
examples-vite-web ⬜️ Ignored (Inspect) Jun 12, 2024 7:32am

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

packages/next-swc/crates/next-api/src/app.rs:59:9: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::nodejs::EntryChunkGroupResult`
packages/next-swc/crates/next-api/src/instrumentation.rs:24:9: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::nodejs::EntryChunkGroupResult`
packages/next-swc/crates/next-api/src/pages.rs:57:18: �[38;5;9merror[E0432]: unresolved import `turbopack_binding::turbopack::nodejs::EntryChunkGroupResult`
packages/next-swc/crates/next-api/src/app.rs:1189:25: �[38;5;9merror[E0308]: mismatched types
packages/next-swc/crates/next-api/src/instrumentation.rs:126:14: �[38;5;9merror[E0599]: no method named `entry_chunk_group` found for struct `Vc<NodeJsChunkingContext>` in the current scope
packages/next-swc/crates/next-api/src/pages.rs:806:25: �[38;5;9merror[E0308]: mismatched types
error: could not compile `next-api` (lib) due to 6 previous errors

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 12, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 6815cd6 into main Jun 12, 2024
55 of 58 checks passed
@sokra sokra deleted the sokra/memory-improvements branch June 12, 2024 20:05
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
reduce resolve tasks for resolving (vercel/turborepo#8451)
c7e388a 
### Description

That reduces the task count and improve memory usage

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
reduce resolve tasks for resolving (vercel/turborepo#8451)
bd641c3 
### Description

That reduces the task count and improve memory usage

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
reduce resolve tasks for resolving (vercel/turborepo#8451)
a3b6736 
### Description

That reduces the task count and improve memory usage

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
reduce resolve tasks for resolving (vercel/turborepo#8451)
597847e 
### Description

That reduces the task count and improve memory usage

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlyon arlyon arlyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @arlyon