Tree Shaking grouping of items #8420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
sokra
commented
Jun 11, 2024
|
|
||
| export { x }; | ||
|
|
||
| export const y = x; |
There was a problem hiding this comment.
Removing this line fixes the problem
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
sokra
commented
Jun 11, 2024
Comment on lines
288
to
359
| x = 2; | ||
| export { x } from "__TURBOPACK_VAR__" assert { | ||
| __turbopack_var__: true | ||
| }; |
sokra
commented
Jun 11, 2024
Comment on lines
323
to
381
| import "__TURBOPACK_PART__" assert { | ||
| __turbopack_part__: 4 | ||
| }; | ||
| import "__TURBOPACK_PART__" assert { | ||
| __turbopack_part__: 5 | ||
| }; | ||
| import "__TURBOPACK_PART__" assert { | ||
| __turbopack_part__: 6 | ||
| }; |
There was a problem hiding this comment.
Suggested change
| import "__TURBOPACK_PART__" assert { | |
| __turbopack_part__: 4 | |
| }; | |
| import "__TURBOPACK_PART__" assert { | |
| __turbopack_part__: 5 | |
| }; | |
| import "__TURBOPACK_PART__" assert { | |
| __turbopack_part__: 6 | |
| }; |
These are not necessary. It only need to import the last Write to a variable. And the declaration of it
sokra
commented
Jun 11, 2024
Comment on lines
297
to
299
| export { x } from "__TURBOPACK_VAR__" assert { | ||
| __turbopack_var__: true | ||
| }; |
There was a problem hiding this comment.
I feel like it's wrong that a module exports a variable that it didn't declare.
|
cec53bc to
f7b632b
Compare
This reverts commit 63767f7.
kdy1
approved these changes
Jun 17, 2024
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jun 18, 2024
# Turbopack * vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> ### What? Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) ### Why? I improved the performance of the parser by margin.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…orepo#8472) ### Description Extracted from vercel/turborepo#8420 to split diffs for optimization vs intuitiveness ### Testing Instructions --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description add test case ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…orepo#8472) ### Description Extracted from vercel/turborepo#8420 to split diffs for optimization vs intuitiveness ### Testing Instructions --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description add test case ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…orepo#8472) ### Description Extracted from vercel/turborepo#8420 to split diffs for optimization vs intuitiveness ### Testing Instructions --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description add test case ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…orepo#8472) ### Description Extracted from vercel/turborepo#8420 to split diffs for optimization vs intuitiveness ### Testing Instructions --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description add test case ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: 강동윤 (Donny) <kdy1997.dev@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) I improved the performance of the parser by margin.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) I improved the performance of the parser by margin.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
# Turbopack * vercel/turborepo#8473 <!-- Donny/강동윤 - feat: Check the number of direct dependants while tree shaking --> * vercel/turborepo#8420 <!-- Tobias Koppers - Tree Shaking grouping of items --> * vercel/turborepo#8510 <!-- Tobias Koppers - read larger chunks when reading a trace file --> * vercel/turborepo#8509 <!-- Tobias Koppers - avoid duplicates in primary_modules --> * vercel/turborepo#8508 <!-- Tobias Koppers - only create spans for nodes that are actually visited --> * vercel/turborepo#8502 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.95.2` --> ### What? Update `swc_core`. - [CHANGELOG](https://github.com/swc-project/swc/blob/064af5391d8da9599f277bd68fd0b479b0b1235c/CHANGELOG.md#160---2024-06-15) ### Why? I improved the performance of the parser by margin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add test case
Testing Instructions