Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation uses Node.js chunking context instead of browser one #8402

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 10, 2024

Description

Evaluation uses Node.js chunking context instead of browser one.
Renaming

Testing Instructions

@sokra sokra requested a review from a team as a code owner June 10, 2024 14:05
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 9:11am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 9:11am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:11am

Copy link
Contributor

github-actions bot commented Jun 10, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

github-actions bot commented Jun 10, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

@sokra sokra merged commit 4592752 into main Jun 12, 2024
56 of 58 checks passed
@sokra sokra deleted the sokra/browser-node-chunking-context branch June 12, 2024 07:19
sokra added a commit to vercel/next.js that referenced this pull request Jun 12, 2024
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…el/turborepo#8402)

### Description

Evaluation uses Node.js chunking context instead of browser one.
Renaming

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…el/turborepo#8402)

### Description

Evaluation uses Node.js chunking context instead of browser one.
Renaming

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…el/turborepo#8402)

### Description

Evaluation uses Node.js chunking context instead of browser one.
Renaming

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…el/turborepo#8402)

### Description

Evaluation uses Node.js chunking context instead of browser one.
Renaming

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants