fix: Apply paren-remover while minifying
#8348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
timneutkens
previously requested changes
Jun 6, 2024
eps1lon
reviewed
Jun 6, 2024
sokra
approved these changes
Jun 6, 2024
kdy1
commented
Jun 7, 2024
| @@ -0,0 +1,30 @@ | |||
| function toFixed(value, maxDecimals, roundingFunction, optionals) { | |||
There was a problem hiding this comment.
This test is copied from swc-project/swc#8442 (SWC PR for paren_remover)
There was a problem hiding this comment.
Note: I also verified this fix by disabling paren_remover in the testing system for SWC minifier
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Jun 7, 2024
* vercel/turborepo#8347 <!-- Tobias Koppers - Small tree shaking fix and test case update --> * vercel/turborepo#8348 <!-- Donny/강동윤 - fix: Apply `paren-remover` while minifying -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This is required to fix https://vercel.slack.com/archives/C04KC8A53T7/p1717599802994489 ### Testing Instructions Closes SWC-171
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This is required to fix https://vercel.slack.com/archives/C04KC8A53T7/p1717599802994489 ### Testing Instructions Closes SWC-171
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This is required to fix https://vercel.slack.com/archives/C04KC8A53T7/p1717599802994489 ### Testing Instructions Closes SWC-171
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This is required to fix https://vercel.slack.com/archives/C04KC8A53T7/p1717599802994489 ### Testing Instructions Closes SWC-171
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8347 <!-- Tobias Koppers - Small tree shaking fix and test case update --> * vercel/turborepo#8348 <!-- Donny/강동윤 - fix: Apply `paren-remover` while minifying -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is required to fix https://vercel.slack.com/archives/C04KC8A53T7/p1717599802994489
Testing Instructions
Closes SWC-171