Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client disallowed transform #8336

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 5, 2024

Description

needed for next.js to disallow "use client" on middleware and instrumentation

Testing Instructions

@sokra sokra requested a review from a team as a code owner June 5, 2024 19:54
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 7:55pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 7:55pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm
examples-native-web ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 5, 2024 7:55pm

Copy link
Contributor

github-actions bot commented Jun 5, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jun 5, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit fb3a61a into main Jun 5, 2024
53 of 54 checks passed
@sokra sokra deleted the sokra/disallowed-client-transform branch June 5, 2024 20:17
huozhi pushed a commit to vercel/next.js that referenced this pull request Jun 5, 2024
* vercel/turborepo#8336 <!-- Tobias Koppers - add
client disallowed transform -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

needed for next.js to disallow "use client" on middleware and
instrumentation

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

needed for next.js to disallow "use client" on middleware and
instrumentation

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

needed for next.js to disallow "use client" on middleware and
instrumentation

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

needed for next.js to disallow "use client" on middleware and
instrumentation

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#8336 <!-- Tobias Koppers - add
client disallowed transform -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants