Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic in debug mode #8324

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix panic in debug mode #8324

merged 1 commit into from
Jun 11, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 5, 2024

Description

getting the id of the root span is not valid

Testing Instructions

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 2:04pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 2:04pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm
examples-native-web ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm
examples-svelte-web ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm
examples-vite-web ⬜️ Ignored (Inspect) Jun 5, 2024 2:04pm

@sokra sokra marked this pull request as ready for review June 5, 2024 14:04
@sokra sokra requested a review from a team as a code owner June 5, 2024 14:04
@sokra sokra requested a review from timneutkens June 5, 2024 14:04
Copy link
Contributor

github-actions bot commented Jun 5, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Jun 5, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Jun 5, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 973eb82 into main Jun 11, 2024
56 of 58 checks passed
@sokra sokra deleted the sokra/fix-panic-trace-viewer branch June 11, 2024 06:48
kdy1 added a commit to vercel/next.js that referenced this pull request Jun 11, 2024
# Turbopack

* vercel/turborepo#8324 <!-- Tobias Koppers - fix panic in debug mode -->
* vercel/turborepo#8395 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.93.2` -->


### What?


Update `swc_core`. 

### Why?

Update `swc_core`. The regression of minifier is fixed by swc-project/swc#9031


### How?
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

getting the id of the root span is not valid

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

getting the id of the root span is not valid

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

getting the id of the root span is not valid

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

getting the id of the root span is not valid

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
* vercel/turborepo#8324 <!-- Tobias Koppers - fix panic in debug mode -->
* vercel/turborepo#8395 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.93.2` -->

Update `swc_core`.

Update `swc_core`. The regression of minifier is fixed by swc-project/swc#9031
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
# Turbopack

* vercel/turborepo#8324 <!-- Tobias Koppers - fix panic in debug mode -->
* vercel/turborepo#8395 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.93.2` -->

### What?

Update `swc_core`.

### Why?

Update `swc_core`. The regression of minifier is fixed by swc-project/swc#9031

### How?
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	packages/next/package.json
#	pnpm-lock.yaml
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
# Turbopack

* vercel/turborepo#8324 <!-- Tobias Koppers - fix panic in debug mode -->
* vercel/turborepo#8395 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.93.2` -->


### What?


Update `swc_core`. 

### Why?

Update `swc_core`. The regression of minifier is fixed by swc-project/swc#9031


### How?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants