Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory and consolidate shared vs transient cells #8263

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

arlyon
Copy link
Contributor

@arlyon arlyon commented May 31, 2024

Description

This change reworks the structure to drop an option such that data which is colocated with its type information doesn't need to store it twice.

Testing Instructions

Existing tests should suffice.

Copy link

vercel bot commented May 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:42am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:42am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 25, 2024 5:42am

Copy link
Contributor Author

arlyon commented May 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @arlyon and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented May 31, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Contributor

github-actions bot commented May 31, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 31, 2024

✅ This change can build next-swc

@sokra sokra merged commit b953c89 into main Jul 25, 2024
55 of 56 checks passed
@sokra sokra deleted the arlyon/memory-overhead branch July 25, 2024 05:57
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…repo#8263)

### Description

This change reworks the structure to drop an option such that data which
is colocated with its type information doesn't need to store it twice.

### Testing Instructions

Existing tests should suffice.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…repo#8263)

### Description

This change reworks the structure to drop an option such that data which
is colocated with its type information doesn't need to store it twice.

### Testing Instructions

Existing tests should suffice.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…repo#8263)

### Description

This change reworks the structure to drop an option such that data which
is colocated with its type information doesn't need to store it twice.

### Testing Instructions

Existing tests should suffice.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…repo#8263)

### Description

This change reworks the structure to drop an option such that data which
is colocated with its type information doesn't need to store it twice.

### Testing Instructions

Existing tests should suffice.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants