Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve performance test case #8169

Merged
merged 1 commit into from
May 17, 2024
Merged

improve performance test case #8169

merged 1 commit into from
May 17, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented May 17, 2024 •
edited
Loading

Description

Make it no longer flaky

Testing Instructions

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:15pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 1:15pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 17, 2024 1:15pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 1:15pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 17, 2024 1:15pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 17, 2024 1:15pm
examples-native-web ⬜️ Ignored (Inspect) May 17, 2024 1:15pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 1:15pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 1:15pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 1:15pm

@sokra sokra requested a review from a team as a code owner May 17, 2024 13:05
@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_common`.
    ... required by package `swc_core v0.92.5`
    ... which satisfies dependency `swc_core = "^0.92.5"` of package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=e4ccbd3632dd7bacef51e00589b32ca2606a00e1#14cb94ba)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.33.26` are: 0.33.26

all possible versions conflict with previously selected packages.

  previously selected package `swc_common v0.33.24`
    ... which satisfies dependency `swc_common = "^0.33.20"` (locked to 0.33.24) of package `swc_core v0.90.33`
    ... which satisfies dependency `swc_core = "^0.90.33"` (locked to 0.90.33) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_common` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 17, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 11e59b9 into main May 17, 2024
47 of 50 checks passed
@sokra sokra deleted the sokra/many-children branch May 17, 2024 14:36
Neosoulink pushed a commit to Neosoulink/turbo that referenced this pull request Jun 14, 2024
@sokra @Neosoulink
improve performance test case (vercel#8169)
c3ec3e7 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
improve performance test case (vercel/turborepo#8169)
a75a72a 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
improve performance test case (vercel/turborepo#8169)
3f8d743 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
improve performance test case (vercel/turborepo#8169)
74ec636 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
improve performance test case (vercel/turborepo#8169)
72ba0fc 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sokra