Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove websocket dependency in turbo-trace-server #8118

Merged

Conversation

timneutkens
Copy link
Member

Description

Hoping this fixes vercel/next.js#65527 (comment) 🤞

Testing Instructions

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:08pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:08pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:08pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 3:08pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 3:08pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 3:08pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 3:08pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 3:08pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 3:08pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 3:08pm

@timneutkens timneutkens requested a review from a team as a code owner May 9, 2024 14:57
@turbo-orchestrator turbo-orchestrator bot added needs: triage New issues get this label. Remove it after triage owned-by: turbopack labels May 9, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented May 9, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 9, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented May 9, 2024

⚠ CI failed ⚠

The following steps have failed in CI:

  • Turbopack Rust tests (linux)

See workflow summary for details

@sokra sokra merged commit a3ca7ff into main May 9, 2024
42 of 47 checks passed
@sokra sokra deleted the 05-09-Remove_websocket_dependency_in_turbo-trace-server branch May 9, 2024 15:11
Neosoulink pushed a commit to Neosoulink/turbo that referenced this pull request Jun 14, 2024
### Description

Hoping this fixes
vercel/next.js#65527 (comment) 🤞


<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
)

### Description

Hoping this fixes
#65527 (comment) 🤞


<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
)

### Description

Hoping this fixes
#65527 (comment) 🤞


<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
)

### Description

Hoping this fixes
#65527 (comment) 🤞


<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
)

### Description

Hoping this fixes
#65527 (comment) 🤞


<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants