Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix source map produced by lightningcss #7977

Merged
merged 7 commits into from
Apr 22, 2024
Merged

fix: Fix source map produced by lightningcss #7977

merged 7 commits into from
Apr 22, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 16, 2024

Description

This PR prepends /turbopack to source map paths.

Closes PACK-2965

Testing Instructions

I updated tests

@kdy1 kdy1 self-assigned this Apr 16, 2024
@kdy1 kdy1 requested a review from a team as a code owner April 16, 2024 01:09
@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:58am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:58am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:58am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:58am
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Apr 22, 2024 6:58am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:58am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:58am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:58am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:58am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:58am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:58am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=f26d232835e6a82bdc2f6d998177f68dde2edb34#b0d32831)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.90.33` are: 0.90.36, 0.90.35, 0.90.34, 0.90.33

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.90.30`
    ... which satisfies dependency `swc_core = "^0.90.30"` (locked to 0.90.30) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 @sokra
Update crates/turbopack-css/src/process.rs
677002b 
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@kdy1 kdy1 enabled auto-merge (squash) April 22, 2024 06:38
@kdy1 kdy1 merged commit 4011e25 into main Apr 22, 2024
44 of 47 checks passed
@kdy1 kdy1 deleted the kdy1/pack-2965 branch April 22, 2024 06:48
@kwonoj kwonoj mentioned this pull request Apr 22, 2024
Closed
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kdy1 @sokra
fix: Fix source map produced by lightningcss (vercel/turborepo#7977)
cd7e2f1 
### Description

This PR prepends `/turbopack` to source map paths.

Closes PACK-2965

### Testing Instructions

I updated tests

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1 @sokra
fix: Fix source map produced by lightningcss (vercel/turborepo#7977)
6629581 
### Description

This PR prepends `/turbopack` to source map paths.

Closes PACK-2965

### Testing Instructions

I updated tests

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kdy1 @sokra
fix: Fix source map produced by lightningcss (vercel/turborepo#7977)
0da4074 
### Description

This PR prepends `/turbopack` to source map paths.

Closes PACK-2965

### Testing Instructions

I updated tests

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kdy1 @sokra
fix: Fix source map produced by lightningcss (vercel/turborepo#7977)
d9fce10 
### Description

This PR prepends `/turbopack` to source map paths.

Closes PACK-2965

### Testing Instructions

I updated tests

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @sokra