Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing async loader #7959

Merged
merged 3 commits into from
Apr 15, 2024
Merged

fix missing async loader #7959

merged 3 commits into from
Apr 15, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 15, 2024 •
edited by padmaia
Loading

Description

generate empty async loader when module is already available, instead of omitting the async loader

Testing Instructions

fixes vercel/next.js#64494

Closes PACK-2959

@sokra sokra requested a review from a team as a code owner April 15, 2024 12:36
@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Apr 15, 2024 0:45am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 0:45am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am
examples-native-web ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am
examples-svelte-web ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am
examples-vite-web ⬜️ Ignored (Inspect) Apr 15, 2024 0:45am

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit ab248ec into main Apr 15, 2024
46 of 47 checks passed
@sokra sokra deleted the sokra/fix-async-chunk-loader branch April 15, 2024 13:04
@sokra sokra mentioned this pull request Apr 15, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Apr 15, 2024
@sokra
update turbopack (#64501)
3491417 
* vercel/turborepo#7858 <!-- Tobias Koppers -
refactor GlobalCssAsset to fix dynamic import of css -->
* vercel/turborepo#7944 <!-- Will Binns-Smith -
Update lockfile for compatibility with next.js -->
* vercel/turborepo#7936 <!-- Tobias Koppers - fix
panic when searching an the root span -->
* vercel/turborepo#7959 <!-- Tobias Koppers - fix
missing async loader -->
@stipsan stipsan mentioned this pull request Apr 19, 2024
Closed
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix missing async loader (vercel/turborepo#7959)
8558dae 
### Description

generate empty async loader when module is already available, instead of
omitting the async loader

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes #64494

Closes PACK-2959
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix missing async loader (vercel/turborepo#7959)
cf010a2 
### Description

generate empty async loader when module is already available, instead of
omitting the async loader

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes #64494

Closes PACK-2959
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix missing async loader (vercel/turborepo#7959)
b4687da 
### Description

generate empty async loader when module is already available, instead of
omitting the async loader

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes #64494

Closes PACK-2959
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix missing async loader (vercel/turborepo#7959)
8767ea0 
### Description

generate empty async loader when module is already available, instead of
omitting the async loader

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->

fixes #64494

Closes PACK-2959
@twistershark twistershark mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sokra @kdy1