-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix HMR for cases where chunking changes #7947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
✅ This change can build |
|
add availability info to chunk list hash instead of chunk content avoid chunk lists when HMR isn't enabled
4cae232
to
4715486
Compare
timneutkens
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Apr 16, 2024
* test case for vercel/turborepo#7947 * fix source map retrieval for HMR-updated assets Closes PACK-2944
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description add availability info to chunk list hash instead of chunk content avoid chunk lists when HMR isn't enabled ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2943
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description add availability info to chunk list hash instead of chunk content avoid chunk lists when HMR isn't enabled ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2943
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description add availability info to chunk list hash instead of chunk content avoid chunk lists when HMR isn't enabled ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2943
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description add availability info to chunk list hash instead of chunk content avoid chunk lists when HMR isn't enabled ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2943
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* test case for vercel/turborepo#7947 * fix source map retrieval for HMR-updated assets Closes PACK-2944
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* test case for vercel/turborepo#7947 * fix source map retrieval for HMR-updated assets Closes PACK-2944
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* test case for vercel/turborepo#7947 * fix source map retrieval for HMR-updated assets Closes PACK-2944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add availability info to chunk list hash instead of chunk content avoid chunk lists when HMR isn't enabled
Testing Instructions
Closes PACK-2943