Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HMR for cases where chunking changes #7947

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 11, 2024

Description

add availability info to chunk list hash instead of chunk content avoid chunk lists when HMR isn't enabled

Testing Instructions

Closes PACK-2943

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:15pm
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:15pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:15pm
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:15pm
turbo-turbo-tracing-next-plugin ❌ Failed (Inspect) Apr 15, 2024 9:15pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 9:15pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 9:15pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 9:15pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 9:15pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 9:15pm
rust-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 9:15pm

Copy link
Contributor

github-actions bot commented Apr 11, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Apr 11, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

sokra added 3 commits April 15, 2024 19:46
add availability info to chunk list hash instead of chunk content
avoid chunk lists when HMR isn't enabled
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sokra sokra merged commit c8fd566 into main Apr 16, 2024
48 of 51 checks passed
@sokra sokra deleted the sokra/fix-hmr-chunk-list branch April 16, 2024 07:24
sokra added a commit to vercel/next.js that referenced this pull request Apr 16, 2024
* test case for vercel/turborepo#7947
* fix source map retrieval for HMR-updated assets

Closes PACK-2944
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

add availability info to chunk list hash instead of chunk content avoid
chunk lists when HMR isn't enabled

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2943
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

add availability info to chunk list hash instead of chunk content avoid
chunk lists when HMR isn't enabled

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2943
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

add availability info to chunk list hash instead of chunk content avoid
chunk lists when HMR isn't enabled

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2943
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

add availability info to chunk list hash instead of chunk content avoid
chunk lists when HMR isn't enabled

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2943
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
* test case for vercel/turborepo#7947
* fix source map retrieval for HMR-updated assets

Closes PACK-2944
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
* test case for vercel/turborepo#7947
* fix source map retrieval for HMR-updated assets

Closes PACK-2944
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* test case for vercel/turborepo#7947
* fix source map retrieval for HMR-updated assets

Closes PACK-2944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants