feat(turbopack): Handle fragment in requests #7935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
This reverts commit 1bfe729.
|
I verified that the problematic test case, |
sokra
reviewed
Apr 18, 2024
sokra
reviewed
Apr 22, 2024
| @@ -1882,14 +1929,38 @@ async fn resolve_relative_request( | |||
| options_value, | |||
There was a problem hiding this comment.
You might need to handle fragment here too
sokra
reviewed
Apr 22, 2024
sokra
reviewed
Apr 22, 2024
crates/turbopack-tests/tests/execution/turbopack/resolving/fragment/input/index.js
Show resolved
Hide resolved
sokra
approved these changes
Apr 22, 2024
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 23, 2024
# Turbopack * vercel/turborepo#7935 <!-- Donny/강동윤 - feat(turbopack): Handle fragment in requests --> ### What? turbopack counterpart: vercel/turborepo#7935 ### Why? We need to fix build ### How? Closes PACK-1006
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
# Turbopack * vercel/turborepo#7935 <!-- Donny/강동윤 - feat(turbopack): Handle fragment in requests --> ### What? turbopack counterpart: vercel/turborepo#7935 ### Why? We need to fix build ### How? Closes PACK-1006
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
# Turbopack * vercel/turborepo#7935 <!-- Donny/강동윤 - feat(turbopack): Handle fragment in requests --> ### What? turbopack counterpart: vercel/turborepo#7935 ### Why? We need to fix build ### How? Closes PACK-1006
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#7935 <!-- Donny/강동윤 - feat(turbopack): Handle fragment in requests --> turbopack counterpart: vercel/turborepo#7935 We need to fix build Closes PACK-1006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 1bfe729.
Testing Instructions
vercel/next.js#64232