Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to give a chunking context a name #7930

Merged
merged 1 commit into from
Apr 22, 2024
Merged

allow to give a chunking context a name #7930

merged 1 commit into from
Apr 22, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 10, 2024 •
edited by padmaia
Loading

Description

improves error message

Testing Instructions

Closes PACK-2930

@sokra sokra requested a review from a team as a code owner April 10, 2024 15:32
@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:22am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:22am
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:22am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 6:22am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:22am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:22am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:22am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:22am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:22am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 6:22am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_core`.
    ... required by package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=2ed7290eb804777cfa47eec44ac097b4cbc2a7e2#e3e52e79)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.90.33` are: 0.90.36, 0.90.35, 0.90.34, 0.90.33

all possible versions conflict with previously selected packages.

  previously selected package `swc_core v0.90.30`
    ... which satisfies dependency `swc_core = "^0.90.30"` (locked to 0.90.30) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_core` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra enabled auto-merge (squash) April 11, 2024 05:46
@sokra sokra force-pushed the sokra/chuning-context-name branch from 8959f00 to 6539430 Compare April 22, 2024 06:12
@sokra sokra merged commit 69199de into main Apr 22, 2024
44 of 47 checks passed
@sokra sokra deleted the sokra/chuning-context-name branch April 22, 2024 06:19
@kwonoj kwonoj mentioned this pull request Apr 22, 2024
Closed
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
allow to give a chunking context a name (vercel/turborepo#7930)
c933cd6 
### Description

improves error message

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2930
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
allow to give a chunking context a name (vercel/turborepo#7930)
fbc885d 
### Description

improves error message

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2930
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
allow to give a chunking context a name (vercel/turborepo#7930)
2e269e1 
### Description

improves error message

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2930
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
allow to give a chunking context a name (vercel/turborepo#7930)
80ad27b 
### Description

improves error message

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @ForsakenHarmony