Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "feat(turbopack): Support marking packages as side-effect-free (#7731)" #7861

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Revert "feat(turbopack): Support marking packages as side-effect-free (#7731)" #7861

merged 1 commit into from
Mar 28, 2024

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Mar 28, 2024 •
edited by padmaia
Loading

This reverts commit ad6b88b.

Closes PACK-2869

@wbinnssmith wbinnssmith requested a review from a team as a code owner March 28, 2024 20:18
@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 8:27pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 8:27pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 8:27pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 28, 2024 8:27pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 8:27pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 8:27pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 8:27pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 8:27pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 8:27pm
examples-vite-web ⬜️ Ignored (Inspect) Mar 28, 2024 8:27pm

@wbinnssmith wbinnssmith requested review from kwonoj and sokra March 28, 2024 20:18
@wbinnssmith wbinnssmith requested a review from kdy1 March 28, 2024 20:18
@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

packages/next-swc/crates/next-core/src/next_app/include_modules_module.rs:71:44: �[38;5;9merror[E0050]: method `is_marked_as_side_effect_free` has 1 parameter but the declaration in trait `is_marked_as_side_effect_free` has 2
error: could not compile `next-core` (lib) due to previous error

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@wbinnssmith wbinnssmith merged commit 060a146 into main Mar 28, 2024
48 of 50 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/revert-sideeffects branch March 28, 2024 22:27
kdy1 added a commit that referenced this pull request Mar 29, 2024
@kdy1
Revert "Revert "feat(turbopack): Support marking packages as side-eff…
4190173 
…ect-free (#7731)" (#7861)"

This reverts commit 060a146.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@wbinnssmith
Revert "feat(turbopack): Support marking packages as side-effect-free (…
b16ff8d 
…vercel/turborepo#7731)" (vercel/turborepo#7861)

This reverts commit 202a371.


Closes PACK-2869
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@wbinnssmith
Revert "feat(turbopack): Support marking packages as side-effect-free (…
aa928e8 
…vercel/turborepo#7731)" (vercel/turborepo#7861)

This reverts commit 8419ba2.


Closes PACK-2869
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@wbinnssmith
Revert "feat(turbopack): Support marking packages as side-effect-free (…
6e2c5d2 
…vercel/turborepo#7731)" (vercel/turborepo#7861)

This reverts commit ba7943d.


Closes PACK-2869
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@wbinnssmith
Revert "feat(turbopack): Support marking packages as side-effect-free (…
9e6348a 
…vercel/turborepo#7731)" (vercel/turborepo#7861)

This reverts commit e23eb84.


Closes PACK-2869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwonoj kwonoj kwonoj approved these changes

@sokra sokra sokra approved these changes

@kdy1 kdy1 Awaiting requested review from kdy1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbinnssmith @kwonoj @sokra