Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic in subtract #7859

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix panic in subtract #7859

merged 1 commit into from
Mar 28, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 28, 2024 •
edited by padmaia
Loading

Description

Testing Instructions

Closes PACK-2866

@sokra sokra requested a review from a team as a code owner March 28, 2024 14:28
@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Mar 28, 2024 2:37pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 2:37pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm
examples-gatsby-web ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm
examples-native-web ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm
examples-svelte-web ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm
examples-vite-web ⬜️ Ignored (Inspect) Mar 28, 2024 2:37pm

@github-actions GitHub Actions
Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

⚠️ This change may fail to build next-swc.

Logs 

packages/next-swc/crates/next-core/src/next_app/include_modules_module.rs:71:44: �[38;5;9merror[E0050]: method `is_marked_as_side_effect_free` has 1 parameter but the declaration in trait `is_marked_as_side_effect_free` has 2
error: could not compile `next-core` (lib) due to previous error

See job summary for details

@sokra sokra enabled auto-merge (squash) March 28, 2024 14:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@sokra sokra disabled auto-merge March 28, 2024 16:13
@sokra sokra merged commit abbc632 into main Mar 28, 2024
49 of 50 checks passed
@sokra sokra deleted the sokra/fix-count-hash-map branch March 28, 2024 16:13
@kdy1 kdy1 mentioned this pull request Mar 29, 2024
Closed
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix panic in subtract (vercel/turborepo#7859)
c62e15f 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2866
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix panic in subtract (vercel/turborepo#7859)
e8d325b 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2866
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix panic in subtract (vercel/turborepo#7859)
0e7f8e5 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2866
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix panic in subtract (vercel/turborepo#7859)
859ec70 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arlyon arlyon arlyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @arlyon