Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop excessive cells after task reexecution #7765

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 19, 2024

Description

When cells become unused after recomputation of a task, drop them.

Testing Instructions

Closes PACK-2788

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview Mar 19, 2024 3:57pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 3:57pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm
examples-gatsby-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm
examples-native-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm
examples-svelte-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm
examples-vite-web ⬜️ Ignored (Inspect) Mar 19, 2024 3:57pm

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Mar 19, 2024

🟢 CI successful 🟢

Thanks

@sokra sokra marked this pull request as ready for review March 22, 2024 12:55
@sokra sokra requested a review from a team as a code owner March 22, 2024 12:55
@timneutkens timneutkens merged commit adbfe4c into main Apr 17, 2024
50 checks passed
@timneutkens timneutkens deleted the sokra/excessive-cells branch April 17, 2024 11:48
kdy1 added a commit to vercel/next.js that referenced this pull request Apr 22, 2024
# Turbopack

* vercel/turborepo#7992 <!-- hrmny -
build(turbo-repository): fix napi build with LLD -->
* vercel/turborepo#7765 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
* vercel/turborepo#7955 <!-- Donny/강동윤 - chore:
Update `styled-jsx` -->
* vercel/turborepo#7987 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.33` -->

### What?

Update swc crates to
swc-project/swc@0f07acb

### Why?

To keep in sync.

### How?

Closes PACK-2968
kwonoj added a commit that referenced this pull request Apr 22, 2024
kwonoj added a commit that referenced this pull request Apr 22, 2024
Reverts #7765

Seems like it's causing a regression, will revisit later.

Closes PACK-2985
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

When cells become unused after recomputation of a task, drop them.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2788
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
…o#8018)

Reverts vercel/turborepo#7765

Seems like it's causing a regression, will revisit later.

Closes PACK-2985
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When cells become unused after recomputation of a task, drop them.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2788
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…o#8018)

Reverts vercel/turborepo#7765

Seems like it's causing a regression, will revisit later.

Closes PACK-2985
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

When cells become unused after recomputation of a task, drop them.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2788
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
…o#8018)

Reverts vercel/turborepo#7765

Seems like it's causing a regression, will revisit later.

Closes PACK-2985
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

When cells become unused after recomputation of a task, drop them.

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2788
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
…o#8018)

Reverts vercel/turborepo#7765

Seems like it's causing a regression, will revisit later.

Closes PACK-2985
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
* vercel/turborepo#7992 <!-- hrmny -
build(turbo-repository): fix napi build with LLD -->
* vercel/turborepo#7765 <!-- Tobias Koppers - Drop
excessive cells after task reexecution -->
* vercel/turborepo#7955 <!-- Donny/강동윤 - chore:
Update `styled-jsx` -->
* vercel/turborepo#7987 <!-- Donny/강동윤 - build:
Update `swc_core` to `v0.90.33` -->

Update swc crates to
swc-project/swc@0f07acb

To keep in sync.

Closes PACK-2968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants