Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turbopack-ecmascript): cache external modules with wrapper #7742

Merged
merged 1 commit into from
Apr 11, 2024
Merged

feat(turbopack-ecmascript): cache external modules with wrapper #7742

merged 1 commit into from
Apr 11, 2024

Conversation

ForsakenHarmony
Copy link
Contributor

Description

This should prevent issues when an external module is removed from the require cache leading to 2 version used from the bundle.

@vercel Vercel
Copy link

vercel bot commented Mar 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 8:18pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 8:18pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 8:18pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 8:18pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 8:18pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 8:18pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 8:18pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 8:18pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 8:18pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 8:18pm

@ForsakenHarmony ForsakenHarmony mentioned this pull request Mar 15, 2024
Merged
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from fe70ef7 to c9e675e Compare March 18, 2024 16:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

✅ This change can build next-swc

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from c9e675e to 5ab1367 Compare April 9, 2024 21:11
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 5ab1367 to ce7dc39 Compare April 9, 2024 21:19
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 65a6767 to 4d82afa Compare April 11, 2024 16:29
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 4d82afa to 9f72164 Compare April 11, 2024 16:36
@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review April 11, 2024 16:37
@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner April 11, 2024 16:37
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 9f72164 to 66c3b81 Compare April 11, 2024 16:37
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2622-cache-external-modules-during-evaluation branch from 66c3b81 to 891eb79 Compare April 11, 2024 20:08
@ForsakenHarmony ForsakenHarmony merged commit 0417d4b into main Apr 11, 2024
48 of 50 checks passed
@ForsakenHarmony ForsakenHarmony deleted the hrmny/pack-2622-cache-external-modules-during-evaluation branch April 11, 2024 21:26
@sokra sokra mentioned this pull request Apr 15, 2024
Merged
ForsakenHarmony added a commit that referenced this pull request Apr 15, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrapp…
07540b8 
…er (#7742)"

This reverts commit 0417d4b.
@ForsakenHarmony ForsakenHarmony mentioned this pull request Apr 15, 2024
Merged
sokra pushed a commit that referenced this pull request Apr 15, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
f91c908 
…per (#7742)" (#7969)

### Description

Reverts #7742 #7961 #7963
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
595cfef 
…el/turborepo#7742)

### Description

This should prevent issues when an external module is removed from the
require cache leading to 2 version used from the bundle.
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
58eab89 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
b3c15bf 
…el/turborepo#7742)

### Description

This should prevent issues when an external module is removed from the
require cache leading to 2 version used from the bundle.
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
6a406fb 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
7f2c9be 
…el/turborepo#7742)

### Description

This should prevent issues when an external module is removed from the
require cache leading to 2 version used from the bundle.
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
679c73a 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
feat(turbopack-ecmascript): cache external modules with wrapper (verc…
f9e52e2 
…el/turborepo#7742)

### Description

This should prevent issues when an external module is removed from the
require cache leading to 2 version used from the bundle.
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@ForsakenHarmony
Revert "feat(turbopack-ecmascript): cache external modules with wrap…
a188c77 
…per (vercel/turborepo#7742)" (vercel/turborepo#7969)

### Description

Reverts vercel/turborepo#7742 #7961 vercel/turborepo#7963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForsakenHarmony @sokra