Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to use full urls in browser runtime #7712

Merged
merged 2 commits into from
Mar 12, 2024
Merged

allow to use full urls in browser runtime #7712

merged 2 commits into from
Mar 12, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 12, 2024

Description

Testing Instructions

Closes PACK-2724

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:54pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:54pm
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:54pm
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 8:54pm
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:54pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:54pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:54pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:54pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:54pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 8:54pm

Copy link
Contributor

github-actions bot commented Mar 12, 2024

⚠️ This change may fail to build next-swc.

Logs

error: failed to select a version for `proc-macro2`.
    ... required by package `turbo-tasks-macros v0.1.0 (https://github.com/vercel/turbo?rev=a0881ee94db7f0711e9f213bd4ff78eeba82366b#77bdb61a)`
    ... which satisfies git dependency `turbo-tasks-macros` of package `turbo-tasks v0.1.0 (https://github.com/vercel/turbo?rev=a0881ee94db7f0711e9f213bd4ff78eeba82366b#77bdb61a)`
    ... which satisfies git dependency `turbo-tasks` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^1.0.79` are: 1.0.79

all possible versions conflict with previously selected packages.

  previously selected package `proc-macro2 v1.0.66`
    ... which satisfies dependency `proc-macro2 = "^1"` (locked to 1.0.66) of package `napi-derive v2.15.0`
    ... which satisfies dependency `napi-derive = "^2"` (locked to 2.15.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`

failed to select a version for `proc-macro2` which could resolve this conflict

See job summary for details

Copy link
Contributor

github-actions bot commented Mar 12, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Mar 12, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 70c36cb into main Mar 12, 2024
44 of 47 checks passed
@sokra sokra deleted the sokra/edge-assets branch March 12, 2024 20:54
sokra added a commit to vercel/next.js that referenced this pull request Mar 12, 2024
### What?

add support for `new URL(..., import.meta.url)` assets in edge. e. g.
needed for og-image.

### Why?

### Turbopack Changes

* vercel/turborepo#7712 <!-- Tobias Koppers - allow
to use full urls in browser runtime -->

Closes PACK-2725
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2724
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2724
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2724
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants