Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update to eslint 9 #113

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

acomanescu
Copy link

BREAKING CHANGE: will not work with eslint 8 due to flat config format

Usage:

const nodeConfig = require('@vercel/style-guide/eslint/node');
const typescriptConfig = require('@vercel/style-guide/eslint/typescript');
const browserConfig = require('@vercel/style-guide/eslint/browser');
const reactConfig = require('@vercel/style-guide/eslint/react');
const nextConfig = require('@vercel/style-guide/eslint/next');
// ... other config files

module.exports = [
  ...nodeConfig,
  ...typescriptConfig,
  ...browserConfig,
  ...reactConfig,
  ...nextConfig,
  {
    languageOptions: {
      parserOptions: {
        project: './tsconfig.json', // if you need TS support
      },
    },
    settings: {
      'import/resolver': {
        typescript: {
          project: './tsconfig.json',  // if you need TS support
        },
      },
    },
    rules: {
      // ... rule overrides
    },
  }
];

BREAKING CHANGE: will not work with eslint 8 due to flat config format
Copy link

socket-security bot commented Oct 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/core@7.26.0 Transitive: environment, filesystem, shell +39 11.2 MB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/eslint-parser@7.25.9 unsafe +7 399 kB nicolo-ribaudo
npm/@commitlint/cli@19.5.0 Transitive: environment, eval, filesystem, shell, unsafe +104 10.7 MB bycedric, escapedcat, marionebl, ...1 more
npm/@commitlint/config-conventional@19.5.0 Transitive: filesystem +10 4.22 MB bycedric, escapedcat, marionebl, ...1 more
npm/@rushstack/eslint-patch@1.10.4 None 0 255 kB odspnpm
npm/@typescript-eslint/eslint-plugin@8.11.0 Transitive: environment, filesystem +39 8.15 MB bradzacher, jameshenry
npm/@typescript-eslint/parser@8.11.0 Transitive: environment, filesystem +32 3.4 MB bradzacher, jameshenry
npm/eslint-import-resolver-typescript@3.6.3 Transitive: environment, filesystem, unsafe +30 1.21 MB jounqin
npm/eslint-plugin-import@2.31.0 Transitive: environment, eval, filesystem, unsafe +103 8.4 MB benmosher, jfmengels, ljharb
npm/eslint-plugin-jest@28.8.3 filesystem Transitive: environment +42 4.5 MB aaronabramov, jeysal, jsonp, ...6 more
npm/eslint-plugin-jsx-a11y@6.10.1 Transitive: eval +104 12.3 MB evcohen, jessebeach, lencioni, ...1 more
npm/eslint-plugin-playwright@2.0.0 None +2 307 kB mxschmitt
npm/eslint-plugin-prettier@5.2.1 Transitive: environment +5 249 kB jounqin
npm/eslint-plugin-react-hooks@5.0.0 None 0 0 B
npm/eslint-plugin-react@7.37.2 Transitive: environment, eval, filesystem +114 8.36 MB ljharb, yannickcr
npm/eslint-plugin-testing-library@6.4.0 Transitive: environment, filesystem +44 3.97 MB testing-library-bot
npm/eslint-plugin-tsdoc@0.3.0 Transitive: environment, eval, filesystem, unsafe +15 4.73 MB odspnpm
npm/eslint-plugin-unicorn@56.0.0 Transitive: environment, filesystem, shell, unsafe +68 6.95 MB sindresorhus
npm/eslint-plugin-vitest@0.5.4 Transitive: environment, filesystem +40 4.52 MB veritem
npm/eslint@9.13.0 environment Transitive: eval, filesystem, shell, unsafe +86 10.3 MB eslintbot
npm/husky@9.1.6 environment, filesystem, shell 0 4.03 kB typicode
npm/lint-staged@15.2.10 Transitive: environment, filesystem, shell +54 2.24 MB okonet
npm/prettier-plugin-packagejson@2.5.3 Transitive: environment, filesystem +36 946 kB matzkoh
npm/prettier@3.3.3 environment, filesystem, unsafe 0 7.7 MB prettier-bot
npm/semantic-release@24.2.0 environment, network Transitive: eval, filesystem, shell, unsafe +283 34.3 MB semantic-release-bot
npm/typescript-eslint@8.11.0 Transitive: environment, filesystem +34 4.15 MB jameshenry
npm/typescript@5.6.3 None 0 22.4 MB typescript-bot

🚮 Removed packages: npm/@babel/core@7.24.0, npm/@babel/eslint-parser@7.23.10, npm/@commitlint/cli@19.0.3, npm/@commitlint/config-conventional@19.0.3, npm/@rushstack/eslint-patch@1.7.2, npm/@typescript-eslint/eslint-plugin@7.1.1, npm/@typescript-eslint/parser@7.1.1, npm/eslint-import-resolver-typescript@3.6.1, npm/eslint-plugin-import@2.29.1, npm/eslint-plugin-jest@27.9.0, npm/eslint-plugin-jsx-a11y@6.8.0, npm/eslint-plugin-playwright@1.5.2, npm/eslint-plugin-react-hooks@4.6.0, npm/eslint-plugin-react@7.34.0, npm/eslint-plugin-testing-library@6.2.0, npm/eslint-plugin-tsdoc@0.2.17, npm/eslint-plugin-unicorn@51.0.1, npm/eslint-plugin-vitest@0.3.22, npm/eslint@8.57.0, npm/husky@9.0.11, npm/lint-staged@15.2.2, npm/prettier-plugin-packagejson@2.4.12, npm/prettier@3.2.5, npm/semantic-release@23.0.2, npm/typescript@5.3.3

View full report↗︎

@acomanescu acomanescu mentioned this pull request Oct 26, 2024
@dimitropoulos
Copy link

GREAT timing. Maintenance on turborepo is blocked on needing ESLint 9, so I'll definitely be doing my best to help get this reviewed and merged. Thank you for the PR and stay posted.

@acomanescu
Copy link
Author

Hi @dimitropoulos, is there anything I can do to help having this merged?

@yadokarization
Copy link

Hi @dimitropoulos, just checking in to see if there's an update on the review process. I'm very much looking forward to this being merged.

@DrPye
Copy link

DrPye commented Jan 8, 2025

@dimitropoulos any update on this, this is literally the only package that is stopping us from using next 15!

@yadokarization
Copy link

Hi @mrmckeb, are there any plans to maintain this repository? It seems that several PRs are pending review without any progress.
This package is really useful for us. Thanks!

@dimitropoulos
Copy link

hi everyone! sorry. things move so fast here at Vercel, wow! I'll take a look at this in the coming week and see what we can do. Internal priorities regarding ESLint in general don't directly align with this, but hey, that's no reason not to help the community - and that's exactly what I still hope to do.

@gnify
Copy link

gnify commented Jan 11, 2025

Hey, no-floating-decimal and new-parens are deprecated since ESLint v8.53.0. ESLint's team moved them to @stylistic/eslint-plugin-js. Can we move to the alternatives suggested in the docs?

UPD: Also eslint-plugin-vitest is no longer maintained because the original maintainer has lost access to their npm account. @vitest/eslint-plugin should be used for all the latest features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants