Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initializes yoga without race conditions #409

Merged
merged 1 commit into from
Feb 18, 2023
Merged

fix: initializes yoga without race conditions #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/yoga/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,22 @@ export function init(yoga: typeof Yoga) {
Yoga = yoga
}

let initializationPromise = null

export default async function getYoga(): Promise<typeof Yoga> {
if (!Yoga) {
const mod = await import('@yoga')
Yoga = await mod.getYogaModule()
if (Yoga) return Yoga

if (initializationPromise) {
await initializationPromise
return Yoga
}

initializationPromise = import('@yoga')
.then((mod) => mod.getYogaModule())
.then((yogaInstance) => (Yoga = yogaInstance))

await initializationPromise
initializationPromise = null

return Yoga
}