Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yarn.lock from examples #912

Merged
merged 3 commits into from
Jan 29, 2017
Merged

Remove yarn.lock from examples #912

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7c8e2f
Remove yarn.lock from examples
timweprovide Jan 28, 2017
bdf966c
Add yarn.lock to gitignore for examples
timweprovide Jan 28, 2017
37689c7
Move yarn ignore to examples directory
timweprovide Jan 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ npm-debug.log

# other
.next
/examples/**/yarn.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you could also just add a gitignore file in the examples folder itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I though we didn't keep any files there. But apparently we also have a .babelrc there 😄

Copy link

@mquandalle mquandalle Jan 29, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to leave a short explanation of why you don't want yarn.lock file as a .gitignore comment, as I guess future readers might get slightly confuse by that.


# coverage
.nyc_output
Expand Down
Loading