Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when metadatabase is set we should not warn #74840

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 13, 2025

What

When you already set metadataBase, we shouldn't warn in next build.
Noticed this bug when testing my own blog and seeing the warning pops up during build

 ⚠ metadataBase property in metadata export is not set for resolving social open graph or twitter images, using "https://huozhi.im". See https://nextjs.org/docs/app/api-refere
nce/functions/generate-metadata#metadatabase

In which case the metadataBase is already set but still get logged as missing

@huozhi huozhi requested a review from ztanner January 13, 2025 23:06
@ijjk
Copy link
Member

ijjk commented Jan 13, 2025

Tests Passed

@huozhi huozhi merged commit e4cffae into canary Jan 14, 2025
128 of 129 checks passed
@huozhi huozhi deleted the fix/donot-warn-when-metadatabase-set branch January 14, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants