Add partial support for "use cache" in metadata route handlers
#74835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display Diff for server.runtime.prod.jsDiff too large to display |
48b39dc to
e9e182d
Compare
huozhi
reviewed
Jan 13, 2025
| @@ -1309,6 +1309,12 @@ export default async function getBaseWebpackConfig( | |||
| }, | |||
| ], | |||
| }, | |||
| resourceQuery: { | |||
| not: [ | |||
| new RegExp(WEBPACK_RESOURCE_QUERIES.metadata), | |||
There was a problem hiding this comment.
These 2 sounds fine to keep as RSC like layers, curious why we need to change them here?
There was a problem hiding this comment.
They will still be in the RSC layer (via issuer layer), but we don't want to apply the next-flight-loader to them, as that would generate additional and conflicting entries, which are already covered by the next-metadata-route-loader entries.
There was a problem hiding this comment.
Without this exclusion, we would generate duplicate export statements like these:
export { $$RSC_SERVER_CACHE_0 as "8056ace5d0b6cd298fba2780df50a7ec233c33eeef" } from "<snip>/app/opengraph-image.tsx?__next_metadata__"
export { $$RSC_SERVER_CACHE_0 as "8056ace5d0b6cd298fba2780df50a7ec233c33eeef" } from "<snip>/app/opengraph-image.tsx?__next_metadata_image_meta__"
I've pushed a (hopefully) clarifying comment.
huozhi
approved these changes
Jan 13, 2025
| connection.dependency as unknown as webpack.NormalModule | ||
| ).request | ||
|
|
||
| if (entryRequest.endsWith(WEBPACK_RESOURCE_QUERIES.metadataRoute)) { |
There was a problem hiding this comment.
Not blocking: would be nice to have a helper to extract entryRequest and handle all cases, using let scares me that we might need to take care of these cases everywhere when we create them.
unstubbable
added a commit
that referenced
this pull request
Jan 15, 2025
…74876) Fixes a regression caused by #74835. [x-ref](https://github.com/vercel/next.js/actions/runs/12773698779/job/35607288377)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using
"use cache"in the special metadata route handlers likesitemap.ts,opengraph-image.tsx,icon.tsx, and other metadata files.reverts #71225
fixes #74146
closes NAR-51
As a follow-up we need to ensure that opengraph image responses do not bail out of static generation when
dynamicIOis enabled.