Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport v14: Static worker fixes (#71564 & #74154) #74284

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Dec 24, 2024

ijjk and others added 2 commits December 24, 2024 09:00
This ensures we properly clean up workers even if an error is thrown
before our normal `.end()` call is done. This can be verified currently
by building `pnpm next test/e2e/app-dir/dynamic-io` which should
encounter an error and fail but the workers were previously being kept
and using lots of CPU, now they are properly cleaned up.
Similar to #73138, this removes the direct usage of `jest-worker` for
the linting/typechecking step in favor of the shared worker that has
built-in handling for propagating errors to the parent process. This is
to ensure that if the worker performing the typechecking/linting
receives a SIGKILL signal (which could happen with an OOM error), that
the parent process exits appropriately.
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 24, 2024
@ijjk
Copy link
Member

ijjk commented Dec 24, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
buildDuration 15.9s 13.9s N/A
buildDurationCached 7.9s 6.8s N/A
nodeModulesSize 201 MB 201 MB ⚠️ +186 B
nextStartRea..uration (ms) 410ms 405ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB
5428.HASH.js gzip 181 B 180 B N/A
6067-HASH.js gzip 5.06 kB 5.06 kB N/A
6428-HASH.js gzip 31.6 kB 31.6 kB N/A
framework-HASH.js gzip 44.9 kB 44.9 kB
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.3 kB 32.3 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 98.5 kB 98.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 185 B N/A
amp-HASH.js gzip 502 B 504 B N/A
css-HASH.js gzip 321 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 258 B 257 B N/A
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 371 B 372 B N/A
image-HASH.js gzip 4.23 kB 4.23 kB N/A
index-HASH.js gzip 259 B 257 B N/A
link-HASH.js gzip 2.67 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 314 B N/A
script-HASH.js gzip 385 B 386 B N/A
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 654 B 654 B
Client Build Manifests
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
_buildManifest.js gzip 483 B 481 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
edge-ssr.js gzip 95.5 kB 95.5 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
middleware-b..fest.js gzip 657 B 657 B
middleware-r..fest.js gzip 156 B 154 B N/A
middleware.js gzip 25.5 kB 25.5 kB
edge-runtime..pack.js gzip 839 B 839 B
Overall change 27 kB 27 kB
Next Runtimes
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 98.3 kB 98.3 kB
app-page-tur..prod.js gzip 100 kB 100 kB
app-page-tur..prod.js gzip 94.3 kB 94.3 kB
app-page.run...dev.js gzip 146 kB 146 kB
app-page.run..prod.js gzip 92.8 kB 92.8 kB
app-route-ex...dev.js gzip 22.5 kB 22.5 kB
app-route-ex..prod.js gzip 15.9 kB 15.9 kB
app-route-tu..prod.js gzip 15.9 kB 15.9 kB
app-route-tu..prod.js gzip 15.6 kB 15.6 kB
app-route.ru...dev.js gzip 22.1 kB 22.1 kB
app-route.ru..prod.js gzip 15.6 kB 15.6 kB
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.2 kB 23.2 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.6 kB 51.6 kB
Overall change 960 kB 960 kB
build cache Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js backport/74154 Change
0.pack gzip 1.63 MB 1.63 MB N/A
index.pack gzip 114 kB 114 kB ⚠️ +478 B
Overall change 114 kB 114 kB ⚠️ +478 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: 0456316

@ztanner ztanner marked this pull request as ready for review December 24, 2024 17:21
@ztanner ztanner requested a review from ijjk December 24, 2024 17:21
@ztanner ztanner merged commit 6c06474 into 14-2-1 Dec 24, 2024
50 of 55 checks passed
@ztanner ztanner deleted the backport/74154 branch December 24, 2024 19:03
@github-actions github-actions bot added the locked label Jan 8, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants