-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline tests for integration/react-18 #65199
Conversation
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for edge-ssr.jsDiff too large to display |
Adds indirection when trying to find a failing test or focusing on one.
e843b22
to
4dfd98f
Compare
|
||
import { join } from 'path' | ||
|
||
import cheerio from 'cheerio' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make it a e2e test and specify the version? And we can test both 18 and 19 beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning to support 18 and 19 in Next.js?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe migrate these to test/e2e
and use nextTestSetup
to isolate them?
Do we have a project that's tracking that instead? I'm trying to land the React sync and don't want to get side-tracked in big refactoring projects. |
... and move it to
react-current-version
in preparation of #65058If you want to split tests, create a separate .test file so that it's easy to find where a (failing) test is located.
There's more wrong with this test with regard to cleanup but I'm not digging into that now.
Closes NEXT-3262