Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Turbo #32703

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Bump Turbo #32703

merged 3 commits into from
Jan 4, 2022

Conversation

jaredpalmer
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@jaredpalmer jaredpalmer changed the title Bump-turbo Bump Turbo Dec 21, 2021
@jaredpalmer jaredpalmer changed the base branch from canary to fix/native-builds December 21, 2021 14:54
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 4, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
buildDuration 14.6s 14.8s ⚠️ +217ms
buildDurationCached 3.3s 3.3s ⚠️ +56ms
nodeModulesSize 340 MB 340 MB ⚠️ +7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
/ failed reqs 0 0
/ total time (seconds) 3.031 3.134 ⚠️ +0.1
/ avg req/sec 824.76 797.77 ⚠️ -26.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.381 1.409 ⚠️ +0.03
/error-in-render avg req/sec 1809.66 1774.11 ⚠️ -35.55
Client Bundles (main, webpack, commons)
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.1 kB 27.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 70.9 kB 70.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.74 kB 4.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
buildDuration 16s 16.1s ⚠️ +88ms
buildDurationCached 3.2s 3.3s ⚠️ +111ms
nodeModulesSize 340 MB 340 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
/ failed reqs 0 0
/ total time (seconds) 3.015 2.983 -0.03
/ avg req/sec 829.12 838.05 +8.93
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.423 1.319 -0.1
/error-in-render avg req/sec 1757.18 1895.03 +137.85
Client Bundles (main, webpack, commons)
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 906 B 906 B
image-HASH.js gzip 4.76 kB 4.76 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary jaredpalmer/next.js bump-turbo Change
index.html gzip 531 B 531 B
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 2869ef7

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@ijjk ijjk merged commit 10a98cb into vercel:fix/native-builds Jan 4, 2022
ijjk added a commit that referenced this pull request Jan 4, 2022
* Fix build-native jobs

* Update to latest turbo

* fix extra space

* fix windows shell

* Update to latest turbo

* Bump Turbo (#32703)

* Bump turbo to canary

* Bump turbo

* Update yaml too

* add less specific restore key

* update more restore keys

* Fix non-unique key and cache wasm build

* ensure turbo is installed for new jobs

* remove old wasm cache

* update directory check

* bump

* re-add if publish checks

Co-authored-by: Jared Palmer <jared@jaredpalmer.com>
@vercel vercel locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants