Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document staticPageGenerationTimeout config #32306

Merged
merged 6 commits into from
Dec 8, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 8, 2021

Adds note to documentation for the new static generation timeout.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

x-ref: #30110

huozhi
huozhi previously approved these changes Dec 8, 2021
Co-authored-by: Steven <steven@ceriously.com>
@ijjk ijjk requested review from styfle and huozhi December 8, 2021 22:17
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be more specific about "no activity occurs"? Could a response be streaming for 60 seconds and still timeout?

@ijjk
Copy link
Member Author

ijjk commented Dec 8, 2021

@styfle re-worded the no activity a bit, a page has to finish getStaticProps/rendering needs to complete for some path in the worker for the timeout to not be hit

@ijjk ijjk requested a review from styfle December 8, 2021 22:25
Co-authored-by: Steven <steven@ceriously.com>
@ijjk ijjk requested a review from styfle December 8, 2021 22:32
styfle
styfle previously approved these changes Dec 8, 2021
@ijjk ijjk merged commit 8d241ac into vercel:canary Dec 8, 2021
@ijjk ijjk deleted the docs/static-generation-timeout branch December 8, 2021 23:05
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants