next/jest: Ensure typeof window is not transformed in jsdom environment

[timneutkens]

Found that when the target is jsdom instead of node the "typeof window" transform is incorrect. This was causing an unexpected failure in on of the tests for vercel.com.

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

Feature

• Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
• Related issues linked using fixes #number
• Integration tests added
• Documentation added
• Telemetry added. In case of a feature if it's used or not.
• Errors have helpful link attached, see contributing.md

Documentation / Examples

• Make sure the linting passes by running yarn lint

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
buildDuration	20.5s	20.7s	⚠️ +222ms
buildDurationCached	4s	4s	⚠️ +4ms
nodeModulesSize	335 MB	335 MB	⚠️ +408 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.298	3.312	⚠️ +0.01
/ avg req/sec	758.01	754.81	⚠️ -3.2
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.597	1.597	✓
/error-in-render avg req/sec	1565.4	1565.62	+0.22

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.3 kB	28.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.2 kB	72.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
index.html gzip	522 B	522 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	516 B	516 B	✓
Overall change	1.57 kB	1.57 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
buildDuration	21.5s	21.3s	-196ms
buildDurationCached	3.9s	3.9s	-18ms
nodeModulesSize	335 MB	335 MB	⚠️ +408 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.317	3.364	⚠️ +0.05
/ avg req/sec	753.7	743.16	⚠️ -10.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.651	1.65	0
/error-in-render avg req/sec	1514.62	1515.1	+0.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.5 kB	28.5 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.2 kB	13.2 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js fix/typeof-window-jest	Change
index.html gzip	521 B	521 B	✓
link.html gzip	534 B	534 B	✓
withRouter.html gzip	515 B	515 B	✓
Overall change	1.57 kB	1.57 kB	✓

Commit: baf5423