fix(middleware): fetch resource may be a URL instance (or any stringifiable value)

[panva]

The resource argument¹ in fetch may also be an instance of URL (or any other stringifiable value) but the sandbox variant of middlewares doesn't support that.

export async function middleware(req, ev) {
  await fetch(new URL('https://www.googleapis.com/oauth2/v3/certs'), {
    redirect: 'manual',
    method: 'GET',
  })

  return new Response(JSON.stringify({}), { status: 200 });
}

This is fixing the use of e.g. URL instance in fetch.

TypeError: initurl.startsWith is not a function
  at getFetchURL (/my-next-app/node_modules/next/dist/server/web/sandbox/sandbox.js:246:17)
  at fetch (/my-next-app/node_modules/next/dist/server/web/sandbox/sandbox.js:77:29)
  at Object.middleware [as handler] (webpack-internal:///./pages/_middleware.js:86:15)
  at async adapter (webpack-internal:///./node_modules/next/dist/server/web/adapter.js:30:22)
  at async DevServer.runMiddleware (/my-next-app/node_modules/next/dist/server/next-server.js:430:26)
  at async DevServer.runMiddleware (/my-next-app/node_modules/next/dist/server/dev/next-dev-server.js:394:28)
  at async Object.fn (/my-next-app/node_modules/next/dist/server/next-server.js:807:34)
  at async Router.execute (/my-next-app/node_modules/next/dist/server/router.js:211:32)
  at async DevServer.run (/my-next-app/node_modules/next/dist/server/next-server.js:1115:29)
  at async DevServer.run (/my-next-app/node_modules/next/dist/server/dev/next-dev-server.js:440:20)

Footnotes

1. https://developer.mozilla.org/en-US/docs/Web/API/fetch#parameters ↩

[ijjk]

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
buildDuration	24.2s	23.9s	-333ms
buildDurationCached	4.7s	4.7s	-62ms
nodeModulesSize	335 MB	335 MB	⚠️ +34 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.037	4.056	⚠️ +0.02
/ avg req/sec	619.31	616.3	⚠️ -3.01
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.137	2.125	-0.01
/error-in-render avg req/sec	1170.04	1176.53	+6.49

Client Bundles (main, webpack, commons)

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.3 kB	28.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	72.2 kB	72.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.3 kB	13.3 kB	✓

Client Build Manifests

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
index.html gzip	522 B	522 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	515 B	515 B	✓
Overall change	1.57 kB	1.57 kB	✓

---

Default Build with SWC

General Overall increase ⚠️

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
buildDuration	26.9s	26.4s	-475ms
buildDurationCached	4.6s	4.8s	⚠️ +132ms
nodeModulesSize	335 MB	335 MB	⚠️ +34 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.099	4.042	-0.06
/ avg req/sec	609.88	618.57	+8.69
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.135	2.144	⚠️ +0.01
/error-in-render avg req/sec	1170.79	1166.29	⚠️ -4.5

Client Bundles (main, webpack, commons)

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.5 kB	28.5 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72.5 kB	72.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.2 kB	13.2 kB	✓

Client Build Manifests

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	panva/next.js fix-fetch-url	Change
index.html gzip	522 B	522 B	✓
link.html gzip	534 B	534 B	✓
withRouter.html gzip	516 B	516 B	✓
Overall change	1.57 kB	1.57 kB	✓

Commit: 9d09c7d