Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep using checkout instead of cache for building swc #30923

Merged
merged 4 commits into from
Nov 3, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 3, 2021

It seems the actions/cache is OS specific so we can't re-use the build cache against all build targets so this re-adds actions/checkout and installs @napi-rs/cli each time.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Nov 3, 2021
@ijjk
Copy link
Member Author

ijjk commented Nov 3, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
buildDuration 21s 21.3s ⚠️ +317ms
buildDurationCached 4.4s 4.4s ⚠️ +18ms
nodeModulesSize 293 MB 293 MB -18 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.391 3.368 -0.02
/ avg req/sec 737.22 742.24 +5.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.545 1.544 0
/error-in-render avg req/sec 1617.67 1618.86 +1.19
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
buildDuration 22.9s 22.6s -270ms
buildDurationCached 4.5s 4.5s -77ms
nodeModulesSize 293 MB 293 MB -18 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
/ failed reqs 0 0
/ total time (seconds) 3.379 3.366 -0.01
/ avg req/sec 739.96 742.74 +2.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.642 1.608 -0.03
/error-in-render avg req/sec 1522.32 1554.95 +32.63
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/os-specific-cache Change
index.html gzip 522 B 522 B
link.html gzip 536 B 536 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: a75f222

@ijjk ijjk marked this pull request as ready for review November 3, 2021 23:25
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a revert of the previous PR, right?

@ijjk
Copy link
Member Author

ijjk commented Nov 3, 2021

More of a continuation

@ijjk ijjk merged commit fc096d0 into canary Nov 3, 2021
@ijjk ijjk deleted the fix/os-specific-cache branch November 3, 2021 23:35
@padmaia
Copy link
Member

padmaia commented Nov 3, 2021

@styfle Kind of, we went back to using the checkout action instead of the cache action, but we also needed to add - run: npm i -g @napi-rs/cli@1.2.1 now that we aren't using npx.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants