-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postinstall script to install native packages #30850
Merged
Merged
+58
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padmaia
requested review from
huozhi,
ijjk,
shuding,
styfle and
timneutkens
as code owners
November 2, 2021 22:39
padmaia
commented
Nov 2, 2021
ijjk
reviewed
Nov 2, 2021
padmaia
force-pushed
the
fix/keep-binaries-up-to-date
branch
from
November 2, 2021 22:46
6cd382b
to
3480071
Compare
ijjk
reviewed
Nov 2, 2021
ijjk
reviewed
Nov 2, 2021
This comment has been minimized.
This comment has been minimized.
Co-authored-by: JJ Kasper <jj@jjsweb.site>
ijjk
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 🎉
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
buildDuration | 18.5s | 18.7s | |
buildDurationCached | 4s | 3.9s | -49ms |
nodeModulesSize | 293 MB | 293 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.946 | 2.949 | 0 |
/ avg req/sec | 848.48 | 847.85 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.427 | 1.353 | -0.07 |
/error-in-render avg req/sec | 1751.62 | 1847.74 | +96.12 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 28 kB | 28 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 71.9 kB | 71.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.23 kB | 1.23 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 327 B | 327 B | ✓ |
dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 635 B | 635 B | ✓ |
image-HASH.js gzip | 4.44 kB | 4.44 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 1.87 kB | 1.87 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
334f979574ae..6f4.css gzip | 106 B | 106 B | ✓ |
Overall change | 13.1 kB | 13.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
index.html gzip | 521 B | 521 B | ✓ |
link.html gzip | 533 B | 533 B | ✓ |
withRouter.html gzip | 515 B | 515 B | ✓ |
Overall change | 1.57 kB | 1.57 kB | ✓ |
Default Build with SWC
General Overall increase ⚠️
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
buildDuration | 19.9s | 20.1s | |
buildDurationCached | 4.1s | 4.1s | |
nodeModulesSize | 293 MB | 293 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.934 | 2.908 | -0.03 |
/ avg req/sec | 852.07 | 859.81 | +7.74 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.367 | 1.371 | 0 |
/error-in-render avg req/sec | 1829.4 | 1823.94 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 28.2 kB | 28.2 kB | ✓ |
webpack-HASH.js gzip | 1.43 kB | 1.43 kB | ✓ |
Overall change | 72.1 kB | 72.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.22 kB | 1.22 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 622 B | 622 B | ✓ |
image-HASH.js gzip | 4.46 kB | 4.46 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 1.91 kB | 1.91 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
334f979574ae..6f4.css gzip | 106 B | 106 B | ✓ |
Overall change | 13.1 kB | 13.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
_buildManifest.js gzip | 460 B | 460 B | ✓ |
Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | padmaia/next.js fix/keep-binaries-up-to-date | Change | |
---|---|---|---|
index.html gzip | 521 B | 521 B | ✓ |
link.html gzip | 534 B | 534 B | ✓ |
withRouter.html gzip | 516 B | 516 B | ✓ |
Overall change | 1.57 kB | 1.57 kB | ✓ |
I've commented in the commit to master instead of here: b2b7e78 Please consider reverting this change. |
I've responded on the commit as well, but this is just for local development of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
postinstall
script that downloads the most recent binary packages instead of adding them asoptionalDependencies
of the root package. Adding these packages asoptionalDependencies
causes problems because theyarn.lock
needs to be updated during the publish job, but that job happens on a protected branch.Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint