-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regenerator path #30786
Merged
Merged
Add regenerator path #30786
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
huozhi,
ijjk,
padmaia,
shuding and
styfle
as code owners
November 2, 2021 08:53
This comment has been minimized.
This comment has been minimized.
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
buildDuration | 24.8s | 24.6s | -131ms |
buildDurationCached | 5.2s | 5.3s | |
nodeModulesSize | 293 MB | 293 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 4.069 | 4.02 | -0.05 |
/ avg req/sec | 614.42 | 621.91 | +7.49 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 2.077 | 2.027 | -0.05 |
/error-in-render avg req/sec | 1203.39 | 1233.17 | +29.78 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 28 kB | 28 kB | ✓ |
webpack-HASH.js gzip | 1.45 kB | 1.45 kB | ✓ |
Overall change | 71.9 kB | 71.9 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.23 kB | 1.23 kB | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 327 B | 327 B | ✓ |
dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 635 B | 635 B | ✓ |
image-HASH.js gzip | 4.44 kB | 4.44 kB | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 1.87 kB | 1.87 kB | ✓ |
routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
script-HASH.js gzip | 383 B | 383 B | ✓ |
withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
334f979574ae..6f4.css gzip | 106 B | 106 B | ✓ |
Overall change | 13.1 kB | 13.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
_buildManifest.js gzip | 459 B | 459 B | ✓ |
Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
index.html gzip | 534 B | 534 B | ✓ |
link.html gzip | 547 B | 547 B | ✓ |
withRouter.html gzip | 528 B | 528 B | ✓ |
Overall change | 1.61 kB | 1.61 kB | ✓ |
Diffs
Diff for _app-HASH.js
@@ -25,9 +25,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _assertThisInitialized(self) {
if (self === void 0) {
throw new ReferenceError(
@@ -194,11 +192,11 @@
* `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
* This allows for keeping state between navigation, custom error handling, injecting additional data.
*/ _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(param) {
+ _runtimeJs.default.mark(function _callee(param) {
var Component = param.Component,
ctx = param.ctx;
var pageProps;
- return _regeneratorRuntime.default.wrap(function _callee$(_ctx) {
+ return _runtimeJs.default.wrap(function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
case 0:
Diff for main-HASH.js
@@ -208,9 +208,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _arrayWithHoles(arr) {
if (Array.isArray(arr)) return arr;
}
@@ -702,7 +700,7 @@
var CachedComponent;
function _initNext() {
_initNext = _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(param1) {
+ _runtimeJs.default.mark(function _callee(param1) {
var opts = param1 === void 0 ? {} : param1;
var initialErr,
appEntrypoint,
@@ -713,7 +711,7 @@
isValidElementType,
getNodeError,
renderCtx;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -903,9 +901,9 @@
}
function _render() {
_render = _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(renderingProps) {
+ _runtimeJs.default.mark(function _callee(renderingProps) {
var renderErr;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -3723,9 +3721,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _arrayWithHoles(arr) {
if (Array.isArray(arr)) return arr;
}
@@ -4482,7 +4478,7 @@
key: "change",
value: function change(method, url, as, options, forcedScroll) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var shouldResolveHref,
prevLocale,
@@ -4528,7 +4524,7 @@
_scroll,
shouldScroll,
resetScroll;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5157,10 +5153,10 @@
loadErrorFail
) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var Component, styleSheets, props, routeInfo;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5292,7 +5288,7 @@
routeProps
) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var _this,
existingRouteInfo,
@@ -5308,7 +5304,7 @@
_this1,
fresh,
data;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5566,7 +5562,7 @@
var asPath = param === void 0 ? url : param,
options = param1 === void 0 ? {} : param1;
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var _this,
parsed,
@@ -5580,7 +5576,7 @@
rewritesResult,
effects,
route;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5726,14 +5722,14 @@
key: "fetchComponent",
value: function fetchComponent(route) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var _this,
cancelled,
cancel,
handleCancelled,
componentResult;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5833,7 +5829,7 @@
key: "_preflightRequest",
value: function _preflightRequest(options) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var ref,
cleanedAs,
@@ -5847,7 +5843,7 @@
cleanRedirect,
newUrl,
newAs;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -6791,9 +6787,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _arrayWithoutHoles(arr) {
if (Array.isArray(arr)) {
for (var i = 0, arr2 = new Array(arr.length); i < arr.length; i++) {
@@ -7072,9 +7066,9 @@
}
function _loadGetInitialProps() {
_loadGetInitialProps = _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(App, ctx) {
+ _runtimeJs.default.mark(function _callee(App, ctx) {
var ref, message, res, props, message1;
- return _regeneratorRuntime.default.wrap(function _callee$(_ctx) {
+ return _runtimeJs.default.wrap(function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
case 0:
Diff for index.html
@@ -19,11 +19,11 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-0731cdfd7668c24a.js"
+ src="/_next/static/chunks/main-03d23aa6386b6696.js"
defer=""
></script>
<script
- src="/_next/static/chunks/pages/_app-de3f211ea2b76ae1.js"
+ src="/_next/static/chunks/pages/_app-c41d5dc8a84968ce.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,11 +19,11 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-0731cdfd7668c24a.js"
+ src="/_next/static/chunks/main-03d23aa6386b6696.js"
defer=""
></script>
<script
- src="/_next/static/chunks/pages/_app-de3f211ea2b76ae1.js"
+ src="/_next/static/chunks/pages/_app-c41d5dc8a84968ce.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,11 +19,11 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-0731cdfd7668c24a.js"
+ src="/_next/static/chunks/main-03d23aa6386b6696.js"
defer=""
></script>
<script
- src="/_next/static/chunks/pages/_app-de3f211ea2b76ae1.js"
+ src="/_next/static/chunks/pages/_app-c41d5dc8a84968ce.js"
defer=""
></script>
<script
Default Build with SWC (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
buildDuration | 26.6s | 26.7s | |
buildDurationCached | 5.2s | 5.2s | |
nodeModulesSize | 293 MB | 293 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 4.001 | 4.01 | |
/ avg req/sec | 624.92 | 623.43 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 2.119 | 2.099 | -0.02 |
/error-in-render avg req/sec | 1180.05 | 1190.78 | +10.73 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
450.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
main-HASH.js gzip | 28.2 kB | 28.2 kB | ✓ |
webpack-HASH.js gzip | 1.43 kB | 1.43 kB | ✓ |
Overall change | 72.1 kB | 72.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.22 kB | 1.22 kB | ✓ |
_error-HASH.js gzip | 180 B | 180 B | ✓ |
amp-HASH.js gzip | 305 B | 305 B | ✓ |
css-HASH.js gzip | 321 B | 321 B | ✓ |
dynamic-HASH.js gzip | 2.38 kB | 2.38 kB | ✓ |
head-HASH.js gzip | 342 B | 342 B | ✓ |
hooks-HASH.js gzip | 622 B | 622 B | ✓ |
image-HASH.js gzip | 4.46 kB | 4.46 kB | ✓ |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 1.91 kB | 1.91 kB | ✓ |
routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
script-HASH.js gzip | 375 B | 375 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
334f979574ae..6f4.css gzip | 106 B | 106 B | ✓ |
Overall change | 13.1 kB | 13.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
_buildManifest.js gzip | 460 B | 460 B | ✓ |
Overall change | 460 B | 460 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/regenerator-path | Change | |
---|---|---|---|
index.html gzip | 532 B | 532 B | ✓ |
link.html gzip | 545 B | 545 B | ✓ |
withRouter.html gzip | 527 B | 527 B | ✓ |
Overall change | 1.6 kB | 1.6 kB | ✓ |
Diffs
Diff for _app-HASH.js
@@ -25,9 +25,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _assertThisInitialized(self) {
if (self === void 0) {
throw new ReferenceError(
@@ -194,11 +192,11 @@
* `App` component is used for initialize of pages. It allows for overwriting and full control of the `page` initialization.
* This allows for keeping state between navigation, custom error handling, injecting additional data.
*/ _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(param) {
+ _runtimeJs.default.mark(function _callee(param) {
var Component = param.Component,
ctx = param.ctx;
var pageProps;
- return _regeneratorRuntime.default.wrap(function _callee$(_ctx) {
+ return _runtimeJs.default.wrap(function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
case 0:
Diff for main-HASH.js
@@ -208,9 +208,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _arrayWithHoles(arr) {
if (Array.isArray(arr)) return arr;
}
@@ -702,7 +700,7 @@
var CachedComponent;
function _initNext() {
_initNext = _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(param1) {
+ _runtimeJs.default.mark(function _callee(param1) {
var opts = param1 === void 0 ? {} : param1;
var initialErr,
appEntrypoint,
@@ -713,7 +711,7 @@
isValidElementType,
getNodeError,
renderCtx;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -903,9 +901,9 @@
}
function _render() {
_render = _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(renderingProps) {
+ _runtimeJs.default.mark(function _callee(renderingProps) {
var renderErr;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -3723,9 +3721,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _arrayWithHoles(arr) {
if (Array.isArray(arr)) return arr;
}
@@ -4482,7 +4478,7 @@
key: "change",
value: function change(method, url, as, options, forcedScroll) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var shouldResolveHref,
prevLocale,
@@ -4528,7 +4524,7 @@
_scroll,
shouldScroll,
resetScroll;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5157,10 +5153,10 @@
loadErrorFail
) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var Component, styleSheets, props, routeInfo;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5292,7 +5288,7 @@
routeProps
) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var _this,
existingRouteInfo,
@@ -5308,7 +5304,7 @@
_this1,
fresh,
data;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5566,7 +5562,7 @@
var asPath = param === void 0 ? url : param,
options = param1 === void 0 ? {} : param1;
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var _this,
parsed,
@@ -5580,7 +5576,7 @@
rewritesResult,
effects,
route;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5726,14 +5722,14 @@
key: "fetchComponent",
value: function fetchComponent(route) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var _this,
cancelled,
cancel,
handleCancelled,
componentResult;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -5833,7 +5829,7 @@
key: "_preflightRequest",
value: function _preflightRequest(options) {
return _asyncToGenerator(
- _regeneratorRuntime.default
+ _runtimeJs.default
.mark(function _callee() {
var ref,
cleanedAs,
@@ -5847,7 +5843,7 @@
cleanRedirect,
newUrl,
newAs;
- return _regeneratorRuntime.default.wrap(
+ return _runtimeJs.default.wrap(
function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
@@ -6791,9 +6787,7 @@
) {
"use strict";
- var _regeneratorRuntime = _interopRequireDefault(
- __webpack_require__(5666)
- );
+ var _runtimeJs = _interopRequireDefault(__webpack_require__(5666));
function _arrayWithoutHoles(arr) {
if (Array.isArray(arr)) {
for (var i = 0, arr2 = new Array(arr.length); i < arr.length; i++) {
@@ -7072,9 +7066,9 @@
}
function _loadGetInitialProps() {
_loadGetInitialProps = _asyncToGenerator(
- _regeneratorRuntime.default.mark(function _callee(App, ctx) {
+ _runtimeJs.default.mark(function _callee(App, ctx) {
var ref, message, res, props, message1;
- return _regeneratorRuntime.default.wrap(function _callee$(_ctx) {
+ return _runtimeJs.default.wrap(function _callee$(_ctx) {
while (1)
switch ((_ctx.prev = _ctx.next)) {
case 0:
Diff for index.html
@@ -19,11 +19,11 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-0731cdfd7668c24a.js"
+ src="/_next/static/chunks/main-03d23aa6386b6696.js"
defer=""
></script>
<script
- src="/_next/static/chunks/pages/_app-de3f211ea2b76ae1.js"
+ src="/_next/static/chunks/pages/_app-c41d5dc8a84968ce.js"
defer=""
></script>
<script
Diff for link.html
@@ -19,11 +19,11 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-0731cdfd7668c24a.js"
+ src="/_next/static/chunks/main-03d23aa6386b6696.js"
defer=""
></script>
<script
- src="/_next/static/chunks/pages/_app-de3f211ea2b76ae1.js"
+ src="/_next/static/chunks/pages/_app-c41d5dc8a84968ce.js"
defer=""
></script>
<script
Diff for withRouter.html
@@ -19,11 +19,11 @@
defer=""
></script>
<script
- src="/_next/static/chunks/main-0731cdfd7668c24a.js"
+ src="/_next/static/chunks/main-03d23aa6386b6696.js"
defer=""
></script>
<script
- src="/_next/static/chunks/pages/_app-de3f211ea2b76ae1.js"
+ src="/_next/static/chunks/pages/_app-c41d5dc8a84968ce.js"
defer=""
></script>
<script
Failing test suitesCommit: 73a40d0 test/integration/preload-viewport/test/index.test.js
Expand output● Prefetching Links in viewport › should not prefetch already loaded scripts
|
This was referenced Nov 6, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30605
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint