Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html #30321

Merged
merged 1 commit into from
Jan 5, 2022
Merged

fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html #30321

merged 1 commit into from
Jan 5, 2022

Conversation

gfortaine
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 26, 2021
@gfortaine gfortaine force-pushed the bugfix/fix-example-cms-contentful branch from 4cc4438 to 777cb6e Compare October 26, 2021 14:54
@gfortaine gfortaine closed this Dec 24, 2021
@gfortaine gfortaine deleted the bugfix/fix-example-cms-contentful branch December 24, 2021 23:38
@gfortaine gfortaine restored the bugfix/fix-example-cms-contentful branch December 26, 2021 23:07
@gfortaine gfortaine reopened this Dec 26, 2021
@gfortaine gfortaine force-pushed the bugfix/fix-example-cms-contentful branch from 9e99be1 to c829474 Compare December 26, 2021 23:15
@leerob
Copy link
Member

leerob commented Jan 4, 2022

Could you share more about this issue?

@gfortaine
Copy link
Contributor Author

gfortaine commented Jan 4, 2022 •
edited
Loading

This PR tries to fix 2 issues with the current implementation of api/preview :

• missing content-type for response

• missing html closing tag

Indeed, we have encountered these bugs by copy-pasting the example

@gfortaine gfortaine force-pushed the bugfix/fix-example-cms-contentful branch from d882975 to 7d6a3e4 Compare January 4, 2022 23:32
@gfortaine gfortaine force-pushed the bugfix/fix-example-cms-contentful branch from 7d6a3e4 to 90d3b1d Compare January 5, 2022 16:13
ijjk
ijjk approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 4a2bfa7 into vercel:canary Jan 5, 2022
teleaziz added a commit to teleaziz/next.js that referenced this pull request Jan 5, 2022
@teleaziz
Merge branch 'canary' of github.com:vercel/next.js into cms-builder-i…
c9fadc8 
…o-example

* 'canary' of github.com:vercel/next.js:
  [chore] Update `deta` version in examples (vercel#30204)
  fix: typescript example supporting strict w/ version >= 4.4 (vercel#33042)
  Avoid page double render with emotion vanilla (vercel#30541)
  converted the old tailwind css example to typescript  (vercel#32808)
  fix(examples/cms-contentful): add correct Content-Type + missing closing tag for html (vercel#30321)
  Ensure NODE_ENV is not inlined for next/jest (vercel#33032)
  Rename api in with-redis example (vercel#33016)
  Remove unused turbo remote cache env vars (vercel#33030)
  v12.0.8-canary.17
  Re-enable turbo caching for swc build jobs (vercel#32617)
  feat(cli): introduce `next info` CLI command (vercel#32972)
  fix(examples): add missing dependencies wo (vercel#32977)
  Updated wrong link to example of gtag init in measuring-performance.md (vercel#32974)
  v12.0.8-canary.16
  Revert "Reduce install size for linux glibc/musl (vercel#32850)" (vercel#32973)
  Ensure middleware is output in standalone mode (vercel#32967)
  v12.0.8-canary.15
  Reduce install size for linux glibc/musl (vercel#32850)
  Fixes issue with makeStylesheetInert (vercel#32027)
  Ensure setImmediate and punycode are polyfilled (vercel#32768)
@gfortaine gfortaine deleted the bugfix/fix-example-cms-contentful branch January 5, 2022 20:27
@vercel vercel locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gfortaine @leerob @ijjk