Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial test trace outputs #30246

Merged
merged 10 commits into from
Oct 25, 2021
Merged

Add initial test trace outputs #30246

merged 10 commits into from
Oct 25, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 25, 2021

This adds uploading test traces from playwright and .next/trace when a test fails to allow investigating flakes that aren't able to be reproduced easily. This also updates the swc test for the new expected output.

The playwright traces can be viewed with yarn playwright show-trace ./path/to-playwright-trace.zip and the next-trace file can viewed with jaegar or ./scripts/trace-to-tree.mjs.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Oct 25, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk changed the title Investigate flakey dev tests Add initial test trace outputs Oct 25, 2021
@ijjk
Copy link
Member Author

ijjk commented Oct 25, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/test-traces Change
buildDuration 20.5s 20.5s ⚠️ +48ms
buildDurationCached 4s 4s -5ms
nodeModulesSize 196 MB 196 MB ⚠️ +6 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/test-traces Change
/ failed reqs 0 0
/ total time (seconds) 3.445 3.462 ⚠️ +0.02
/ avg req/sec 725.62 722.15 ⚠️ -3.47
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.598 1.539 -0.06
/error-in-render avg req/sec 1564.33 1624.84 +60.51
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/test-traces Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.7 kB 27.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/test-traces Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/test-traces Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/test-traces Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/test-traces Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/test-traces Change
buildDuration 16.9s 17.4s ⚠️ +439ms
buildDurationCached 4.1s 4.1s -9ms
nodeModulesSize 196 MB 196 MB ⚠️ +6 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/test-traces Change
/ failed reqs 0 0
/ total time (seconds) 3.337 3.325 -0.01
/ avg req/sec 749.14 751.84 +2.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.589 1.73 ⚠️ +0.14
/error-in-render avg req/sec 1573.57 1444.91 ⚠️ -128.66
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/test-traces Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/test-traces Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/test-traces Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/test-traces Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/test-traces Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 83ab8f4

@ijjk ijjk marked this pull request as ready for review October 25, 2021 06:18
@timneutkens timneutkens merged commit 474f1e7 into vercel:canary Oct 25, 2021
@timneutkens timneutkens deleted the add/test-traces branch October 25, 2021 06:21
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants