Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some labels for middleware stuff #30241

Merged
merged 5 commits into from
Oct 24, 2021
Merged

fix some labels for middleware stuff #30241

merged 5 commits into from
Oct 24, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Oct 24, 2021

  • show (client only) for _middleware files
  • show f symbol for _middleware files in summary tree
  • only show legend for symbols used
    image

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 24, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@sokra sokra marked this pull request as ready for review October 24, 2021 20:31
@ijjk
Copy link
Member

ijjk commented Oct 24, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
buildDuration 16.7s 16.8s ⚠️ +71ms
buildDurationCached 3.4s 3.4s -24ms
nodeModulesSize 196 MB 196 MB ⚠️ +1.13 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
/ failed reqs 0 0
/ total time (seconds) 2.801 2.825 ⚠️ +0.02
/ avg req/sec 892.42 885.1 ⚠️ -7.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.325 1.377 ⚠️ +0.05
/error-in-render avg req/sec 1886.55 1815.58 ⚠️ -70.97
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.7 kB 27.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
index.html gzip 535 B 535 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
buildDuration 14.3s 14.3s ⚠️ +22ms
buildDurationCached 3.4s 3.5s ⚠️ +36ms
nodeModulesSize 196 MB 196 MB ⚠️ +1.13 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
/ failed reqs 0 0
/ total time (seconds) 2.815 2.749 -0.07
/ avg req/sec 888.18 909.54 +21.36
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.341 1.3 -0.04
/error-in-render avg req/sec 1863.83 1923.77 +59.94
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 621 B 621 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
9a34b27eb3f9..27d.css gzip 125 B 125 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/middleware-labels Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 807d82f

@ijjk
Copy link
Member

ijjk commented Oct 24, 2021

Failing test suites

Commit: 807d82f

test/e2e/basepath.test.ts

  • basePath > should use urls with basepath in router events for hash changes
  • basePath > should use urls with basepath in router events for failed route change
Expand output

● basePath › should use urls with basepath in router events for hash changes

expect(received).toEqual(expected) // deep equality

- Expected  -  0
+ Received  + 21

@@ -1,7 +1,28 @@
  Array [
    Array [
+     "routeChangeStart",
+     "/docs/hello",
+     Object {
+       "shallow": true,
+     },
+   ],
+   Array [
+     "beforeHistoryChange",
+     "/docs/hello",
+     Object {
+       "shallow": true,
+     },
+   ],
+   Array [
+     "routeChangeComplete",
+     "/docs/hello",
+     Object {
+       "shallow": true,
+     },
+   ],
+   Array [
      "hashChangeStart",
      "/docs/hello#some-hash",
      Object {
        "shallow": false,
      },

  713 |
  714 |         const eventLog = await browser.eval('window._getEventLog()')
> 715 |         expect(eventLog).toEqual([
      |                          ^
  716 |           [
  717 |             'hashChangeStart',
  718 |             `${basePath}/hello#some-hash`,

  at Object.<anonymous> (e2e/basepath.test.ts:715:26)

● basePath › should use urls with basepath in router events for failed route change

expect(received).toEqual(expected) // deep equality

- Expected  -  0
+ Received  + 21

@@ -1,8 +1,29 @@
  Array [
    Array [
      "routeChangeStart",
+     "/docs/hello",
+     Object {
+       "shallow": true,
+     },
+   ],
+   Array [
+     "beforeHistoryChange",
+     "/docs/hello",
+     Object {
+       "shallow": true,
+     },
+   ],
+   Array [
+     "routeChangeComplete",
+     "/docs/hello",
+     Object {
+       "shallow": true,
+     },
+   ],
+   Array [
+     "routeChangeStart",
      "/docs/error-route",
      Object {
        "shallow": false,
      },
    ],

  769 |
  770 |         const eventLog = await browser.eval('window._getEventLog()')
> 771 |         expect(eventLog).toEqual([
      |                          ^
  772 |           ['routeChangeStart', `${basePath}/error-route`, { shallow: false }],
  773 |           [
  774 |             'routeChangeError',

  at Object.<anonymous> (e2e/basepath.test.ts:771:26)

@ijjk ijjk merged commit df613d3 into canary Oct 24, 2021
@ijjk ijjk deleted the bugfix/middleware-labels branch October 24, 2021 22:09
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants