Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest caniuse-lite version #30194

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Update to latest caniuse-lite version #30194

merged 1 commit into from
Oct 23, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 23, 2021

Updates to remove extra stderr logs from outdated caniuse-lite version.

Fixes: https://github.com/vercel/next.js/runs/3981430538?check_suite_focus=true

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 23, 2021
@ijjk
Copy link
Member Author

ijjk commented Oct 23, 2021 •
edited
Loading

Failing test suites

Commit: 2ff167d

test/development/basic-basepath/hmr.test.ts

  • basic HMR > Error Recovery > should recover from errors in the render function
Expand output

● basic HMR › Error Recovery › should recover from errors in the render function

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:458:9)

test/integration/i18n-support-base-path/test/index.test.js

  • i18n Support basePath > production mode > should output correct prerender-manifest
Expand output

● i18n Support basePath › production mode › should output correct prerender-manifest

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `i18n Support basePath production mode should output correct prerender-manifest 2`

- Snapshot  - 4
+ Received  + 4

  {
    "/gsp/fallback/[slug]": {
      "routeRegex": "^\/gsp\/fallback\/([^\/]+?)(?:\/)?$",
      "dataRoute": "/_next/data/BUILD_ID/gsp/fallback/[slug].json",
      "fallback": "/gsp/fallback/[slug].html",
-     "dataRouteRegex": "^\/_next\/data\/BUILD_ID\/gsp\/fallback\/([^\/]+?)\.json$"
+     "dataRouteRegex": "^\/_next\/data\/\BUILD_ID\/gsp\/fallback\/([^\/]+?)\.json$"
    },
    "/gsp/no-fallback/[slug]": {
      "routeRegex": "^\/gsp\/no\-fallback\/([^\/]+?)(?:\/)?$",
      "dataRoute": "/_next/data/BUILD_ID/gsp/no-fallback/[slug].json",
      "fallback": false,
-     "dataRouteRegex": "^\/_next\/data\/BUILD_ID\/gsp\/no\-fallback\/([^\/]+?)\.json$"
+     "dataRouteRegex": "^\/_next\/data\/\BUILD_ID\/gsp\/no\-fallback\/([^\/]+?)\.json$"
    },
    "/not-found/blocking-fallback/[slug]": {
      "routeRegex": "^\/not\-found\/blocking\-fallback\/([^\/]+?)(?:\/)?$",
      "dataRoute": "/_next/data/BUILD_ID/not-found/blocking-fallback/[slug].json",
      "fallback": null,
-     "dataRouteRegex": "^\/_next\/data\/BUILD_ID\/not\-found\/blocking\-fallback\/([^\/]+?)\.json$"
+     "dataRouteRegex": "^\/_next\/data\/\BUILD_ID\/not\-found\/blocking\-fallback\/([^\/]+?)\.json$"
    },
    "/not-found/fallback/[slug]": {
      "routeRegex": "^\/not\-found\/fallback\/([^\/]+?)(?:\/)?$",
      "dataRoute": "/_next/data/BUILD_ID/not-found/fallback/[slug].json",
      "fallback": "/not-found/fallback/[slug].html",
-     "dataRouteRegex": "^\/_next\/data\/BUILD_ID\/not\-found\/fallback\/([^\/]+?)\.json$"
+     "dataRouteRegex": "^\/_next\/data\/\BUILD_ID\/not\-found\/fallback\/([^\/]+?)\.json$"
    }
  }

  1599 |             '/fr/gsp/fallback/first.json',
  1600 |             '/fr/gsp/fallback/hello.json',
> 1601 |           ]
       |            ^
  1602 |         )
  1603 |         return 'yes'
  1604 |       }, 'yes')

  at Object.<anonymous> (integration/i18n-support/test/shared.js:1601:12)

@ijjk
Copy link
Member Author

ijjk commented Oct 23, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/caniuse Change
buildDuration 12.8s 13s ⚠️ +174ms
buildDurationCached 4s 2.9s -1.2s
nodeModulesSize 196 MB 196 MB ⚠️ +3.8 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/caniuse Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.961 3.056 ⚠️ +0.1
/ avg req/sec 844.24 818.08 ⚠️ -26.16
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.42 1.484 ⚠️ +0.06
/error-in-render avg req/sec 1760.37 1685.08 ⚠️ -75.29
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/caniuse Change
651.cd440d20..0b23.js gzip 2.96 kB 2.96 kB ✓
831.695e33f6..205f.js gzip 179 B 179 B ✓
framework-89..a097.js gzip 42.2 kB 42.2 kB ✓
main-167207f..648c.js gzip 26.1 kB 26.1 kB ✓
webpack-f09b..493e.js gzip 1.47 kB 1.47 kB ✓
Overall change 72.9 kB 72.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/caniuse Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/caniuse Change
_app-9fb8765..c13d.js gzip 979 B 979 B ✓
_error-d828d..2954.js gzip 3.06 kB 3.06 kB ✓
amp-5388d1f5..4ce9.js gzip 551 B 551 B ✓
css-10424225..367a.js gzip 329 B 329 B ✓
dynamic-9821..3cd4.js gzip 2.67 kB 2.67 kB ✓
head-1df323b..d261.js gzip 2.32 kB 2.32 kB ✓
hooks-ab0016..b093.js gzip 917 B 917 B ✓
image-a42113..a670.js gzip 5.84 kB 5.84 kB ✓
index-95c8cb..6970.js gzip 260 B 260 B ✓
link-05c99e7..35ec.js gzip 1.66 kB 1.66 kB ✓
routerDirect..6659.js gzip 319 B 319 B ✓
script-d94ba..ed05.js gzip 386 B 386 B ✓
withRouter-7..8b2e.js gzip 317 B 317 B ✓
9a34b27eb3f9..27d.css gzip 125 B 125 B ✓
Overall change 19.7 kB 19.7 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/caniuse Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/caniuse Change
index.html gzip 537 B 537 B ✓
link.html gzip 548 B 548 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/caniuse Change
buildDuration 6.3s 6.3s -12ms
buildDurationCached 2.9s 2.9s ⚠️ +84ms
nodeModulesSize 196 MB 196 MB ⚠️ +3.8 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/caniuse Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.998 2.967 -0.03
/ avg req/sec 833.86 842.58 +8.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.401 1.374 -0.03
/error-in-render avg req/sec 1784.73 1819.87 +35.14
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/caniuse Change
450.fd3ad245..022b.js gzip 179 B 179 B ✓
675-759b108e..1b9a.js gzip 13.8 kB 13.8 kB ✓
framework-13..70b0.js gzip 50.8 kB 50.8 kB ✓
main-d78cd7f..aaf4.js gzip 36.5 kB 36.5 kB ✓
webpack-a7f2..2650.js gzip 1.63 kB 1.63 kB ✓
Overall change 103 kB 103 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/caniuse Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js update/caniuse Change
_app-ae91bc3..d985.js gzip 1.33 kB 1.33 kB ✓
_error-273ac..9ef0.js gzip 180 B 180 B ✓
amp-5f9a7694..99ce.js gzip 315 B 315 B ✓
css-3a1b2477..df1e.js gzip 330 B 330 B ✓
dynamic-e04a..a1b5.js gzip 2.79 kB 2.79 kB ✓
head-7f600d0..daa3.js gzip 356 B 356 B ✓
hooks-bd8c02..0730.js gzip 638 B 638 B ✓
image-6365b7..7506.js gzip 536 B 536 B ✓
index-80be94..e89f.js gzip 262 B 262 B ✓
link-4ee1ea7..8745.js gzip 2.22 kB 2.22 kB ✓
routerDirect..c4aa.js gzip 325 B 325 B ✓
script-67da0..49e6.js gzip 390 B 390 B ✓
withRouter-2..2409.js gzip 322 B 322 B ✓
9a34b27eb3f9..27d.css gzip 125 B 125 B ✓
Overall change 10.1 kB 10.1 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js update/caniuse Change
_buildManifest.js gzip 476 B 476 B ✓
Overall change 476 B 476 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/caniuse Change
index.html gzip 535 B 535 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 2ff167d

@ijjk ijjk merged commit 3274efc into vercel:canary Oct 23, 2021
@ijjk ijjk deleted the update/caniuse branch October 23, 2021 01:36
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @styfle