Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repo-setup when .DS_Store exists #30119

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Fix repo-setup when .DS_Store exists #30119

merged 2 commits into from
Oct 20, 2021

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 20, 2021 •
edited
Loading

When running locally, certain files such as .DS_Store can cause this script to fail.

tmp/packages/.DS_Store/package.json

So we'll skip in those cases.

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Oct 20, 2021
@ijjk ijjk merged commit 094153f into canary Oct 20, 2021
@ijjk ijjk deleted the fix-repo-setup-ds-store branch October 20, 2021 23:13
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi huozhi approved these changes

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@styfle @huozhi @ijjk