Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc #30057

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Update swc #30057

merged 2 commits into from
Oct 19, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 19, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes

@ijjk
Copy link
Member

ijjk commented Oct 19, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-ver-9 Change
buildDuration 12s 12.4s ⚠️ +363ms
buildDurationCached 3s 2.9s -108ms
nodeModulesSize 195 MB 195 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-ver-9 Change
/ failed reqs 0 0
/ total time (seconds) 2.784 2.742 -0.04
/ avg req/sec 898.04 911.75 +13.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.282 1.246 -0.04
/error-in-render avg req/sec 1949.45 2005.71 +56.26
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-9 Change
558.HASH.js gzip 3.02 kB 3.02 kB
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 25 kB 25 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-9 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-9 Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 3.11 kB 3.11 kB
amp-HASH.js gzip 553 B 553 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.73 kB 2.73 kB
head-HASH.js gzip 2.37 kB 2.37 kB
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 5.85 kB 5.85 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.9 kB 19.9 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-9 Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-9 Change
index.html gzip 537 B 537 B
link.html gzip 549 B 549 B
withRouter.html gzip 530 B 530 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-ver-9 Change
buildDuration 6s 6s ⚠️ +85ms
buildDurationCached 3.1s 2.9s -239ms
nodeModulesSize 195 MB 195 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-ver-9 Change
/ failed reqs 0 0
/ total time (seconds) 2.792 2.817 ⚠️ +0.03
/ avg req/sec 895.43 887.49 ⚠️ -7.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.288 1.285 0
/error-in-render avg req/sec 1940.66 1946.28 +5.62
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-ver-9 Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.8 kB 50.8 kB
main-HASH.js gzip 35.2 kB 35.2 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 102 kB 102 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-ver-9 Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-ver-9 Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-ver-9 Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-ver-9 Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: 9d649a7

@ijjk
Copy link
Member

ijjk commented Oct 19, 2021

Failing test suites

Commit: 9d649a7

test/development/basic-basepath/hmr.test.ts

  • basic HMR > Error Recovery > should detect runtime errors on the module scope
  • basic HMR > Hot Module Reloading > editing a page > should update styles correctly
Expand output

● basic HMR › Hot Module Reloading › editing a page › should update styles correctly

TIMED OUT: /200px/

100px

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:165:13)

● basic HMR › Error Recovery › should detect runtime errors on the module scope

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic-basepath/hmr.test.ts:428:9)

@timneutkens timneutkens merged commit 6f5ec2b into vercel:canary Oct 19, 2021
@timneutkens timneutkens deleted the swc-ver-9 branch October 19, 2021 11:34
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
@kdy1 kdy1 self-assigned this Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants