Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest to include notFound revalidate info #30046

Merged
merged 6 commits into from
Oct 19, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 18, 2021

This ensures we include notFound routes in the prerender-manifest routes so that we have the revalidate information available.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 18, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Oct 19, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
buildDuration 14.6s 14.7s ⚠️ +110ms
buildDurationCached 3.5s 3.5s -13ms
nodeModulesSize 195 MB 195 MB -195 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
/ failed reqs 0 0
/ total time (seconds) 3.285 3.288 0
/ avg req/sec 760.99 760.41 ⚠️ -0.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.523 1.599 ⚠️ +0.08
/error-in-render avg req/sec 1641.86 1563.81 ⚠️ -78.05
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
558.HASH.js gzip 3.02 kB 3.02 kB
779.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 25 kB 25 kB
webpack-HASH.js gzip 1.49 kB 1.49 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
_app-HASH.js gzip 977 B 977 B
_error-HASH.js gzip 3.11 kB 3.11 kB
amp-HASH.js gzip 553 B 553 B
css-HASH.js gzip 328 B 328 B
dynamic-HASH.js gzip 2.73 kB 2.73 kB
head-HASH.js gzip 2.37 kB 2.37 kB
hooks-HASH.js gzip 918 B 918 B
image-HASH.js gzip 5.85 kB 5.85 kB
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 1.66 kB 1.66 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 319 B 319 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 19.9 kB 19.9 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
_buildManifest.js gzip 493 B 493 B
Overall change 493 B 493 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
index.html gzip 539 B 539 B
link.html gzip 550 B 550 B
withRouter.html gzip 532 B 532 B
Overall change 1.62 kB 1.62 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
buildDuration 7.1s 7.3s ⚠️ +202ms
buildDurationCached 3.4s 3.4s ⚠️ +6ms
nodeModulesSize 195 MB 195 MB -195 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
/ failed reqs 0 0
/ total time (seconds) 3.376 3.357 -0.02
/ avg req/sec 740.47 744.79 +4.32
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.489 1.467 -0.02
/error-in-render avg req/sec 1679.1 1703.79 +24.69
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
675-HASH.js gzip 13.8 kB 13.8 kB
770.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 50.8 kB 50.8 kB
main-HASH.js gzip 35.2 kB 35.2 kB
webpack-HASH.js gzip 1.64 kB 1.64 kB
Overall change 102 kB 102 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
_app-HASH.js gzip 1.33 kB 1.33 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 315 B 315 B
css-HASH.js gzip 331 B 331 B
dynamic-HASH.js gzip 2.79 kB 2.79 kB
head-HASH.js gzip 355 B 355 B
hooks-HASH.js gzip 637 B 637 B
image-HASH.js gzip 555 B 555 B
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.22 kB 2.22 kB
routerDirect..HASH.js gzip 326 B 326 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 322 B 322 B
bb14e60e810b..30f.css gzip 125 B 125 B
Overall change 10.1 kB 10.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
_buildManifest.js gzip 511 B 511 B
Overall change 511 B 511 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/i18n-prerender-manifest Change
index.html gzip 539 B 539 B
link.html gzip 552 B 552 B
withRouter.html gzip 533 B 533 B
Overall change 1.62 kB 1.62 kB
Commit: 50f0a66

@ijjk ijjk marked this pull request as ready for review October 19, 2021 00:25
@kodiakhq kodiakhq bot merged commit 5e03494 into vercel:canary Oct 19, 2021
@ijjk ijjk deleted the update/i18n-prerender-manifest branch October 19, 2021 00:30
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants