Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Favicons URL mismatch across the project in [examples/blog-starter] #29990

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Fixed Favicons URL mismatch across the project in [examples/blog-starter] #29990

merged 2 commits into from
Oct 19, 2021

Conversation

georgegach
Copy link
Contributor

Bug

There is URL mismatch about the destination of favicons across the project in examples/blog-starter i.e. site.webmanifest and meta.js are in a disagreement, triggering web app manifest initialization errors in Application tab of dev tools. (relevant file)

Fix

This PR:

  1. Renames folder to plural favicons
  2. Adjusts favicons/*.png urls in meta.js

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 17, 2021
ijjk
ijjk approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit ac287e6 into vercel:canary Oct 19, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgegach @ijjk